-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Fetch system index mappings from json file instead of string constants #3153
base: main
Are you sure you want to change the base?
[Enhancement] Fetch system index mappings from json file instead of string constants #3153
Conversation
…ad of string constants Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
d50f8cf
to
63a6d62
Compare
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
…ums rather than use their own mappings Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@@ -18,15 +18,15 @@ | |||
package org.opensearch.ml.common.conversation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@austintlee @HenryL27 I have also modified this class to use the MLIndex enum, please review the same. I didn't want to do a full refactor for now as it may impact functionality. Added as a todo on top of the class.
ml-algorithms/src/test/java/org/opensearch/ml/engine/indices/MLIndicesHandlerTest.java
Show resolved
Hide resolved
Let's add more details about how do you test this feature in the PR description? |
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
|
On it Edit: Fixed - issue was due to eol characters being different on different OS |
…cter issue Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@Zhangxunmt @dhrubo-os please re-review when you get the time I am looking at the test failures, seems to be flaky tests |
Description
Moves the index mappings for system indices into json files and fetches the version from the file itself.
Version should be provided under
"_meta"."schema_version"
All mappings were fetched by using the below method in
MlIndex.java
Related Issues
Resolves #2951
Enhancements
required_fields
object under_meta
object to validate if these fields are present in the mappingThese enhancements will be raised in a separate PR: https://github.com/pyek-bot/ml-commons/pull/1/files
Testing
main
and comparing against new mappings using the above mentioned code blockhttps://github.com/pyek-bot/ml-commons/pull/1/files
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.