-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt to OpenSearch 2.x #69
Conversation
Ok, so one of the drawbacks of branches is that [Use this template] button does not allow to select a branch but will clone the repo (plugin template) with all branches [1] |
i'm aware of this, however i think it's a good approach: when you create the repo from the template you have to toggle the checkbox that it should copy all branches and then you get the only alternative i see is that you could instead create a complete separate repo for 2.x, but that'd not match what actual plugins do which support multiple versions with different branches in the same repo |
resolves opensearch-project#66 Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Thanks @rursprung , we need one more approval to get it in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rursprung !
@@ -114,6 +114,8 @@ run { | |||
useCluster testClusters.integTest | |||
} | |||
|
|||
dependencyLicenses.enabled = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, i just saw this: this is a leftover from when i wrongly added the org.apache.hc.core5
dependency and should've been removed again (since now we don't have any dependency here) :|
i can provide a PR for that next week (or someone else can briefly remove this). sorry about that!
Description
DO NOT MERGE INTO
main
this adapts the template to OpenSearch 2.x (currently:
2.15.0-SNAPSHOT
).as there's no 2.x branch on this repo yet i can only target the
main
branch. i'd suggest that you create a 2.x branch (based off of main; can only be done by maintainers) and then re-target this PR to the 2.x branch.Issues Resolved
resolves #66
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.