remove manual DCO check (done by org-level check) (backport 2.x) #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the DCO check is activated directly on GitHub in the org-level settings for `opensearch-project` (see the [GitHub documentation]). there's no need for the duplicate check implemented in the workflow anymore. other projects which are created based on the template which want a DCO check can also just enable this in their settings. fixes opensearch-project#61 [GitHub documentation]: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-the-commit-signoff-policy-for-your-repository Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
rursprung
requested review from
AmiStrn,
dblock,
saratvemulapalli and
reta
as code owners
reta
approved these changes
Jun 20, 2024
|
the failure is clearly a false-reject: i just removed a GH workflow and now a JUnit test is failing... probably just needs a re-trigger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the DCO check is activated directly on GitHub in the org-level settings for
opensearch-project(see the GitHub documentation). there's no need for the duplicate check implemented in the workflow anymore.other projects which are created based on the template which want a DCO check can also just enable this in their settings.
fixes #61
Issues Resolved
cherry-pick of #92
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.