-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix proxy.md #837
fix proxy.md #837
Conversation
Signed-off-by: jiangying <krivergo3@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 71.95% 70.34% -1.61%
==========================================
Files 91 113 +22
Lines 8001 8896 +895
==========================================
+ Hits 5757 6258 +501
- Misses 2244 2638 +394 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jiangying <krivergo3@gmail.com>
Why doesn't it work with the default connection class? |
i don't know, but it does not work before I added |
There are multiple connection classes, see https://github.com/opensearch-project/opensearch-py/blob/9dd7bf7cb3e80b98fcc256edb9c49cf89202f522/guides/connection_classes.md. The default is |
Agree, this is not a fix to #821 , just a temporary fix to the doc At least Users can get what they want by following the doc after this change |
I agree, I'll merge this. |
related: #821