Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proxy.md #837

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix proxy.md #837

merged 2 commits into from
Oct 23, 2024

Conversation

jiangying000
Copy link
Contributor

@jiangying000 jiangying000 commented Oct 23, 2024

related: #821

Signed-off-by: jiangying <krivergo3@gmail.com>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (ba715b9) to head (05d222b).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   71.95%   70.34%   -1.61%     
==========================================
  Files          91      113      +22     
  Lines        8001     8896     +895     
==========================================
+ Hits         5757     6258     +501     
- Misses       2244     2638     +394     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jiangying <krivergo3@gmail.com>
@dblock
Copy link
Member

dblock commented Oct 23, 2024

Why doesn't it work with the default connection class?

@dblock dblock added the skip-changelog Skips changelog verifier label Oct 23, 2024
@jiangying000
Copy link
Contributor Author

Why doesn't it work with the default connection class?

i don't know, but it does not work before I added connection_class=RequestsHttpConnection,

@dblock
Copy link
Member

dblock commented Oct 23, 2024

RequestsHttpConnection

There are multiple connection classes, see https://github.com/opensearch-project/opensearch-py/blob/9dd7bf7cb3e80b98fcc256edb9c49cf89202f522/guides/connection_classes.md.

The default is Urllib3HttpConnection for synchronous scenarios. The change you are proposing switching a non-working proxy implementation in Urllib3HttpConnection to a working proxy implementation in RequestsHttpConnection, so I don't think this is the right fix, aside of the documentation someone needs to actually fix the problem for proxy support in Urllib3HttpConnection.

@jiangying000
Copy link
Contributor Author

jiangying000 commented Oct 23, 2024

Agree, this is not a fix to #821 , just a temporary fix to the doc

At least Users can get what they want by following the doc after this change

@dblock
Copy link
Member

dblock commented Oct 23, 2024

I agree, I'll merge this.

@dblock dblock merged commit ad1048b into opensearch-project:main Oct 23, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants