Set minimum Java version to 11 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrross
requested review from
ankitkala,
mgodwan,
backslasht and
shwetathareja
as code owners
getsaurabh02
approved these changes
Sep 12, 2024
|
@andrross I believe we need to add 11 to matrix as well here: |
Also add Java 11 and 17 to the precommit workflows. Signed-off-by: Andrew Ross <andrross@amazon.com>
gaiksaya
approved these changes
Sep 12, 2024
peterzhuamazon
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
To add a bit more context, 2.x is still following the compatibility of JDK11.
https://opensearch.org/docs/latest/install-and-configure/install-opensearch/index/#java-compatibility
The JDK21 compatibility is only for main/3.0.0:
opensearch-project/OpenSearch#14011
Thanks @andrross for the change here.
And also include the builds for 11 and 17 jdk check.
peterzhuamazon
merged commit b38bad9
into
opensearch-project:2.17
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set minimum Java version to 11 on the 2.17 branch. This will need to be forward ported to the 2.x branch as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.