-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated JDBC driver in artifacts and download page #1730
Merged
dtaivpp
merged 4 commits into
opensearch-project:main
from
GumpacG:artifacts-jdbc-1.3.0
Jun 23, 2023
Merged
Updated JDBC driver in artifacts and download page #1730
dtaivpp
merged 4 commits into
opensearch-project:main
from
GumpacG:artifacts-jdbc-1.3.0
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws and
nateynateynate
as code owners
June 20, 2023 20:40
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Yury-Fridlyand
approved these changes
Jun 21, 2023
matthewryanwells
approved these changes
Jun 22, 2023
Hi @krisfreedain, would you be able to take a look at this? This is beneficial for Tableau certification in order to get users to download the latest and greatest JDBC driver. |
GumpacG
commented
Jun 22, 2023
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
dtaivpp
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and verified the signature and looks good!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the version of the JDBC driver on the download page is required for Tableau Certification of OpenSearch. The driver has been published and signed using JarSigner as per opensearch-project/opensearch-build#3614.
There is no signature file in the artifacts bucket for the driver because it is not signed with PGP. I've added a command in https://opensearch.org/verify-signatures.html for verifying the driver using jarsigner.
Issues Resolved
#1721
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.