Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated reindex.remote.allowlist setting #5068

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

andrross
Copy link
Member

Description

Test fix to replace usage of a deprecated setting

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (ca5eb23) to head (2d18c8a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5068      +/-   ##
==========================================
- Coverage   71.47%   71.46%   -0.02%     
==========================================
  Files         336      336              
  Lines       22625    22625              
  Branches     3601     3601              
==========================================
- Hits        16171    16168       -3     
- Misses       4654     4658       +4     
+ Partials     1800     1799       -1     

see 3 files with indirect coverage changes

@cwperks cwperks merged commit de1fc49 into opensearch-project:main Jan 29, 2025
41 of 42 checks passed
@andrross andrross deleted the replace-whitelist-setting branch January 29, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants