Skip to content

Add forecast roles and permissions #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

kaituo
Copy link
Contributor

@kaituo kaituo commented Jun 10, 2025

Description

Add forecast roles and indices; format roles.yml

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.
Not a backport.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Yes, opensearch-project/security-dashboards-plugin#2253

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (b25deca) to head (2a4955f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5386      +/-   ##
==========================================
- Coverage   72.19%   72.15%   -0.05%     
==========================================
  Files         382      382              
  Lines       23697    23697              
  Branches     3644     3644              
==========================================
- Hits        17109    17099      -10     
- Misses       4791     4802      +11     
+ Partials     1797     1796       -1     

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shikharj05
Copy link
Collaborator

Thanks @kaituo ! can you help check the failing CIs?

@kaituo kaituo changed the title Update forecast roles and permissions Add forecast roles and permissions Jun 10, 2025
The forecast_read_access and forecast_full_access roles in config/roles.yml have been updated with the correct permissions for the forecasting feature. Forecasting system indices have been added in https://github.com/opensearch-project/anomaly-detection/blob/main/src/main/java/org/opensearch/timeseries/TimeSeriesAnalyticsPlugin.java#L1722

Signed-off-by: Kaituo Li <kaituo@amazon.com>
@cwperks cwperks merged commit 28cb2c8 into opensearch-project:main Jun 10, 2025
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants