This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Complete ADS snapshot cache implementation #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steeling
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio,
trstringer and
keithmattix
as code owners
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
force-pushed
the
feature/snapshot-pub
branch
from
e8af923
to
23b61ba
Compare
shashankram
approved these changes
Aug 25, 2022
keithmattix
approved these changes
Aug 26, 2022
| } | ||
| } | ||
|
|
||
| func (s *Server) allPodUpdater() { |
There was a problem hiding this comment.
We really updated all the pods every time a single pod got an update event? Big save of resources here!
| @@ -44,18 +45,59 @@ func (s *Server) OnStreamOpen(ctx context.Context, streamID int64, typ string) e | |||
| } | |||
|
|
|||
| s.proxyRegistry.RegisterProxy(proxy) | |||
| go func() { | |||
There was a problem hiding this comment.
Does this make sense to abstract into a separate function like in the previous implementation?
There was a problem hiding this comment.
sorry i prematurely merged this.. i'm still investigating ways we can abstract this stuff more. I've taken a note to revisit this :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the ADS snapshot cache implementation, but does not flip the flag to enable it. This is accomplished by:
Part of #2683
Signed-off-by: Sean Teeling seanteeling@microsoft.com