Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@ashwindasr
ashwindasr committed Nov 8, 2024
1 parent e43d0fb commit 0489fee
Showing 1 changed file with 8 additions and 19 deletions.
27 changes: 8 additions & 19 deletions pyartcd/tests/pipelines/test_promote.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -429,12 +429,7 @@ async def test_run_with_standard_assembly_invalid_errata_status(self, load_group
}
} if raise_if_not_found else None)
@patch("pyartcd.pipelines.promote.util.load_releases_config", return_value={
"releases": {"4.10.99": {"assembly": {"type": "standard", "basis": {"reference_releases": {
"x86_64": "nightly-x86_64",
"s390x": "nightly-s390x",
"ppc64le": "nightly-ppc64le",
"aarch64": "nightly-aarch64",
}}}}}
"releases": {"4.10.99": {"assembly": {"type": "standard"}}}
})
@patch("pyartcd.pipelines.promote.util.load_group_config", return_value=Model({
"upgrades": "4.10.98,4.9.99",
Expand Down Expand Up @@ -494,13 +489,13 @@ async def test_run_with_standard_assembly(self, create_cincinnati_prs: AsyncMock
get_release_image_info.assert_any_await("quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64", raise_if_not_found=ANY)
get_release_image_info.assert_any_await("quay.io/openshift-release-dev/ocp-release:4.10.99-s390x", raise_if_not_found=ANY)
build_release_image.assert_any_await("4.10.99", "x86_64", ["4.10.98", "4.9.99"], ["4.11.45"],
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64", "registry.ci.openshift.org/ocp/release:nightly-x86_64", None, keep_manifest_list=False)
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64", None, keep_manifest_list=False)
build_release_image.assert_any_await("4.10.99", "s390x", ["4.10.98", "4.9.99"], ["4.11.45"],
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-s390x", "registry.ci.openshift.org/ocp-s390x/release-s390x:nightly-s390x", None, keep_manifest_list=False)
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-s390x", None, keep_manifest_list=False)
build_release_image.assert_any_await("4.10.99", "ppc64le", ["4.10.98", "4.9.99"], ["4.11.45"],
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-ppc64le", "registry.ci.openshift.org/ocp-ppc64le/release-ppc64le:nightly-ppc64le", None, keep_manifest_list=False)
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-ppc64le", None, keep_manifest_list=False)
build_release_image.assert_any_await("4.10.99", "aarch64", ["4.10.98", "4.9.99"], ["4.11.45"],
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64", "registry.ci.openshift.org/ocp-arm64/release-arm64:nightly-aarch64", None, keep_manifest_list=False)
{"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}, "quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64", None, keep_manifest_list=False)
pipeline._slack_client.bind_channel.assert_called_once_with("4.10.99")
pipeline.get_image_stream_tag.assert_any_await("ocp", "release:4.10.99")
pipeline.tag_release.assert_any_await("quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64", "ocp/release:4.10.99")
Expand Down Expand Up @@ -555,26 +550,23 @@ async def test_promote_arch(self, get_image_stream: AsyncMock, get_release_image
metadata = {"description": "whatever", "url": "https://access.redhat.com/errata/RHBA-2099:2222"}

# test x86_64
reference_release = "whatever-x86_64"
actual = await pipeline._promote_arch(
release_name="4.10.99",
arch="x86_64",
previous_list=previous_list,
next_list=[],
metadata=metadata,
reference_release=reference_release,
tag_stable=True,
assembly_type=AssemblyTypes.CUSTOM
)
get_release_image_info.assert_any_await("quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64")
build_release_image.assert_awaited_once_with("4.10.99", "x86_64", previous_list, [],
metadata, "quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64", f'registry.ci.openshift.org/ocp/release:{reference_release}', None, keep_manifest_list=False)
metadata, "quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64", None, '4.10-art-assembly-4.10.99', keep_manifest_list=False)
get_image_stream_tag.assert_awaited_once_with("ocp", "release:4.10.99")
tag_release.assert_awaited_once_with("quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64", "ocp/release:4.10.99")
self.assertEqual(actual["image"], "quay.io/openshift-release-dev/ocp-release:4.10.99-x86_64")

# test aarch64
reference_release = "whatever-aarch64"
get_release_image_info.reset_mock()
build_release_image.reset_mock()
get_image_stream_tag.reset_mock()
Expand All @@ -585,13 +577,12 @@ async def test_promote_arch(self, get_image_stream: AsyncMock, get_release_image
previous_list=previous_list,
next_list=[],
metadata=metadata,
reference_release=reference_release,
tag_stable=True,
assembly_type=AssemblyTypes.CUSTOM
)
get_release_image_info.assert_any_await("quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64")
build_release_image.assert_awaited_once_with("4.10.99", "aarch64", previous_list, [],
metadata, "quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64", f'registry.ci.openshift.org/ocp-arm64/release-arm64:{reference_release}', None, keep_manifest_list=False)
metadata, "quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64", None, '4.10-art-assembly-4.10.99-arm64', keep_manifest_list=False)
get_image_stream_tag.assert_awaited_once_with("ocp-arm64", "release-arm64:4.10.99")
tag_release.assert_awaited_once_with("quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64", "ocp-arm64/release-arm64:4.10.99")
self.assertEqual(actual["image"], "quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64")
Expand All @@ -602,7 +593,6 @@ async def test_promote_arch(self, get_image_stream: AsyncMock, get_release_image
"dockerImageReference": "quay.io/openshift-release-dev/ocp-release@fake:foobar",
}
}
reference_release = "whatever-aarch64"
get_release_image_info.reset_mock()
build_release_image.reset_mock()
get_image_stream_tag.reset_mock()
Expand All @@ -614,13 +604,12 @@ async def test_promote_arch(self, get_image_stream: AsyncMock, get_release_image
previous_list=previous_list,
next_list=[],
metadata=metadata,
reference_release=reference_release,
tag_stable=True,
assembly_type=AssemblyTypes.CUSTOM
)
get_release_image_info.assert_any_await("quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64")
build_release_image.assert_awaited_once_with("4.10.99", "aarch64", previous_list, [],
metadata, "quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64", f'registry.ci.openshift.org/ocp-arm64/release-arm64:{reference_release}', None, keep_manifest_list=False)
metadata, "quay.io/openshift-release-dev/ocp-release:4.10.99-aarch64", None, '4.10-art-assembly-4.10.99-arm64', keep_manifest_list=False)
get_image_stream_tag.assert_awaited_once_with("ocp-arm64", "release-arm64:4.10.99")
tag_release.assert_not_awaited()

Expand Down

0 comments on commit 0489fee

Please sign in to comment.