Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigstore sign release payloads prior to adding to the release controller #689

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jupierce
Copy link
Contributor

openshift/enhancements#1633 is proposing the use of ClusterImagePolicy/ImagePolicy in order to verify sigstore signatures on a release payload. This is replacing direct CVO based verification of simple signing (based on GPG and filestores).
We want testing by the release controller to exercise validation of the sigstore based signature, so it is necessary to sign the release payload before adding it to the release controller.

openshift/enhancements#1633 is proposing the use
of ClusterImagePolicy/ImagePolicy in order to verify sigstore signatures
on a release payload. This is replacing direct CVO based verification
of simple signing (based on GPG and filestores).
We want testing by the release controller to exercise validation of the
sigstore based signature, so it is necessary to sign the release payload
before adding it to the release controller.
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

@jupierce: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 454ce4a link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thegreyd
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thegreyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c717918 into openshift-eng:main Jun 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants