Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Restore GOFLAGS to default (empty) on all Openshift related runs #568

Conversation

cardil
Copy link
Member

@cardil cardil commented Nov 8, 2024

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Nov 8, 2024
@openshift-ci openshift-ci bot added the approved label Nov 8, 2024
@cardil
Copy link
Member Author

cardil commented Nov 8, 2024

/cc @mgencur
/cc @dsimansk

@cardil
Copy link
Member Author

cardil commented Nov 8, 2024

/cherrypick main

@openshift-cherrypick-robot

@cardil: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Member Author

cardil commented Nov 8, 2024

/cherrypick release-1.16

@openshift-cherrypick-robot

@cardil: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil cardil force-pushed the bugfix/1.15/goflags-restore branch from 0fd6ede to 0b7ea53 Compare November 8, 2024 14:31
@cardil cardil force-pushed the bugfix/1.15/goflags-restore branch from 0b7ea53 to bd2592b Compare November 8, 2024 14:34
Copy link

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Member Author

cardil commented Nov 8, 2024

/override "Red Hat Konflux / kn-plugin-event-test-wathola-forwarder-115-on-pull-request"

Copy link

openshift-ci bot commented Nov 8, 2024

@cardil: Overrode contexts on behalf of cardil: Red Hat Konflux / kn-plugin-event-test-wathola-forwarder-115-on-pull-request

In response to this:

/override "Red Hat Konflux / kn-plugin-event-test-wathola-forwarder-115-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 2300a1b into openshift-knative:release-1.15 Nov 8, 2024
11 of 12 checks passed
@openshift-cherrypick-robot

@cardil: new pull request created: #569

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@cardil: new pull request created: #570

In response to this:

/cherrypick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants