Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.30] Update tekton dependency #645

Conversation

matejvasek
Copy link
Collaborator

@matejvasek matejvasek commented Aug 23, 2023

backport knative#1753
This makes on cluster build work with tekton operator 1.10 and 1.11.

@openshift-ci openshift-ci bot requested review from rhuss and vyasgun August 23, 2023 15:04
@matejvasek matejvasek requested review from dsimansk and jrangelramos and removed request for rhuss and vyasgun August 23, 2023 15:19
@matejvasek matejvasek changed the base branch from serverless-1.30.0 to serverless-1.30 August 23, 2023 16:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (serverless-1.30@6b27b2a). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                 @@
##             serverless-1.30     #645   +/-   ##
==================================================
  Coverage                   ?   60.91%           
==================================================
  Files                      ?       94           
  Lines                      ?    12083           
  Branches                   ?        0           
==================================================
  Hits                       ?     7360           
  Misses                     ?     4059           
  Partials                   ?      664           
Flag Coverage Δ
e2e-test 39.84% <0.00%> (?)
e2e-test-runtime-go 28.13% <0.00%> (?)
e2e-test-runtime-node 29.36% <0.00%> (?)
e2e-test-runtime-python 29.36% <0.00%> (?)
e2e-test-runtime-quarkus 29.49% <0.00%> (?)
e2e-test-runtime-springboot 28.39% <0.00%> (?)
e2e-test-runtime-typescript 29.49% <0.00%> (?)
integration-tests 49.72% <0.00%> (?)
unit-tests-macos-latest 48.72% <0.00%> (?)
unit-tests-ubuntu-latest 49.64% <0.00%> (?)
unit-tests-windows-latest 48.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Fixes: knative#1716

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek matejvasek changed the title deps: update tekton to latest versions (#1753) deps: update tekton to latest versions Aug 23, 2023
@matejvasek
Copy link
Collaborator Author

PTAL @jrangelramos

@matejvasek matejvasek changed the title deps: update tekton to latest versions [serverless-1.30] deps: update tekton to latest versions Aug 23, 2023
@matejvasek
Copy link
Collaborator Author

@dsimansk please check this is a compatible change

@matejvasek matejvasek changed the title [serverless-1.30] deps: update tekton to latest versions [serverless-1.30] Update tekton dependency Aug 23, 2023
@dsimansk
Copy link
Collaborator

/lgtm

@jrangelramos
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Collaborator

@matejvasek @jrangelramos any chance to get the GH actions fixed? Or is it ok to override them for now?

@dsimansk
Copy link
Collaborator

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@dsimansk: No presubmit jobs available for openshift-knative/kn-plugin-func@serverless-1.30

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link
Collaborator

/override "On Cluster RT Test (1.20.5, ubuntu-latest)"
/override "On Cluster Test (1.20.5, ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@dsimansk: Overrode contexts on behalf of dsimansk: On Cluster RT Test (1.20.5, ubuntu-latest), On Cluster Test (1.20.5, ubuntu-latest)

In response to this:

/override "On Cluster RT Test (1.20.5, ubuntu-latest)"
/override "On Cluster Test (1.20.5, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 18b62d2 into openshift-knative:serverless-1.30 Aug 24, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants