Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.30] Update docker dependency #716

Merged
merged 9 commits into from
Oct 17, 2023

Conversation

matejvasek
Copy link
Collaborator

No description provided.

@matejvasek matejvasek requested review from dsimansk and removed request for nainaz October 17, 2023 11:37
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (serverless-1.30@4864fbd). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.30     #716   +/-   ##
==================================================
  Coverage                   ?   50.88%           
==================================================
  Files                      ?       93           
  Lines                      ?    12169           
  Branches                   ?        0           
==================================================
  Hits                       ?     6192           
  Misses                     ?     5421           
  Partials                   ?      556           
Flag Coverage Δ
e2e-test-runtime-go 28.00% <0.00%> (?)
unit-tests-ubuntu-latest 49.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Collaborator

/lgtm

@dsimansk
Copy link
Collaborator

/override "On Cluster Test (1.20.10, ubuntu-latest)"
/override "On Cluster RT Test (1.20.10, ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • On Cluster RT Test (1.20.10, ubuntu-latest)

Only the following failed contexts/checkruns were expected:

  • E2E Test (1.20.2, ubuntu-latest)
  • E2E Test (node)
  • E2E Test (python)
  • E2E Test (quarkus)
  • Integration Test (1.20.2, ubuntu-latest)
  • On Cluster RT Test (1.20.2, ubuntu-latest, s2i)
  • On Cluster Test (1.20.10, ubuntu-latest)
  • On Cluster Test (1.20.2, ubuntu-latest)
  • Unit Test (1.20.2, 17, macos-latest)
  • Unit Test (1.20.2, 17, ubuntu-latest)
  • Unit Test (1.20.2, 17, windows-latest)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "On Cluster Test (1.20.10, ubuntu-latest)"
/override "On Cluster RT Test (1.20.10, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link
Collaborator

/override "On Cluster RT Test (1.20.10, ubuntu-latest)"

@dsimansk
Copy link
Collaborator

/override "On Cluster Test (1.20.10, ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@dsimansk: Overrode contexts on behalf of dsimansk: On Cluster Test (1.20.10, ubuntu-latest)

In response to this:

/override "On Cluster Test (1.20.10, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link
Collaborator

/override "On Cluster RT Test (1.20.10, ubuntu-latest)"

@dsimansk
Copy link
Collaborator

/override

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@dsimansk: /override requires failed status contexts to operate on, but none was given

In response to this:

/override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link
Collaborator

/override ?

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • E2E Test (1.20.2, ubuntu-latest)
  • E2E Test (node)
  • E2E Test (python)
  • E2E Test (quarkus)
  • Integration Test (1.20.2, ubuntu-latest)
  • On Cluster RT Test (1.20.10, ubuntu-latest)
  • On Cluster RT Test (1.20.2, ubuntu-latest, s2i)
  • On Cluster Test (1.20.2, ubuntu-latest)
  • Unit Test (1.20.2, 17, macos-latest)
  • Unit Test (1.20.2, 17, ubuntu-latest)
  • Unit Test (1.20.2, 17, windows-latest)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Oct 17, 2023
@dsimansk
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 17, 2023
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Oct 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

New changes are detected. LGTM label has been removed.

@matejvasek
Copy link
Collaborator Author

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@matejvasek: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link
Collaborator

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Collaborator

dsimansk commented Oct 17, 2023

@matejvasek you can add lgtm label manually as a repo admin. Just in case you ever need it.

@matejvasek matejvasek merged commit 08df1cf into serverless-1.30 Oct 17, 2023
17 of 21 checks passed
@matejvasek matejvasek deleted the matejvasek/update-docker branch September 17, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants