Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.33] Backport PaC fix #774

Merged
merged 3 commits into from
May 30, 2024

Conversation

matejvasek
Copy link
Collaborator

No description provided.

* fix: default NS for PaC

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: make error non-fatal

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: pass correct image to PaC

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* chore: enable gitlab test

---------

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek requested review from dsimansk and jrangelramos and removed request for jrangelramos and nainaz May 30, 2024 14:35
@matejvasek matejvasek changed the title [serverless-1.33] Backport pac fix [serverless-1.33] Backport PaC fix May 30, 2024
@dsimansk
Copy link
Collaborator

/approve
/lgtm

@matejvasek
Copy link
Collaborator Author

/override "On Cluster RT Test (ubuntu-latest, s2i)"

Copy link

openshift-ci bot commented May 30, 2024

@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster RT Test (ubuntu-latest, s2i)

In response to this:

/override "On Cluster RT Test (ubuntu-latest, s2i)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Collaborator Author

/override "On Cluster Test (ubuntu-latest)"

Copy link

openshift-ci bot commented May 30, 2024

@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster Test (ubuntu-latest)

In response to this:

/override "On Cluster Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm label May 30, 2024
Copy link

openshift-ci bot commented May 30, 2024

New changes are detected. LGTM label has been removed.

@matejvasek
Copy link
Collaborator Author

/override "On Cluster RT Test (ubuntu-latest, s2i)"
/override "On Cluster Test (ubuntu-latest)"

Copy link

openshift-ci bot commented May 30, 2024

@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster RT Test (ubuntu-latest, s2i), On Cluster Test (ubuntu-latest)

In response to this:

/override "On Cluster RT Test (ubuntu-latest, s2i)"
/override "On Cluster Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Collaborator Author

/approve
/lgtm

Copy link

openshift-ci bot commented May 30, 2024

@matejvasek: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4ab6599 into serverless-1.33 May 30, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants