Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serverless-1.34] patch bash image #887

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[serverless-1.34] patch bash image #887

merged 1 commit into from
Sep 12, 2024

Conversation

matejvasek
Copy link
Collaborator

No description provided.

@matejvasek
Update bash image
51852b3 
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@openshift-ci openshift-ci bot requested review from nainaz and rhuss September 12, 2024 11:03
@matejvasek matejvasek requested review from dsimansk and jrangelramos and removed request for rhuss and nainaz September 12, 2024 11:03
@matejvasek
Copy link
Collaborator Author

PTAL @jrangelramos @dsimansk

@dsimansk
Copy link
Collaborator

Should we extra it into a variable? Fine to merge as it's now.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Collaborator

dsimansk commented Sep 12, 2024 •
edited
Loading

Hence one more question, is there any generic pipeline bash step? I mean something that is OOTB supported by Tekton without image ref.

@dsimansk
Copy link
Collaborator

dsimansk commented Sep 12, 2024 •
edited
Loading

/test 415-e2e-oncluster-test

WARN[2024-09-12T12:14:39Z] Found 1 conditions for ClusterClaim:
  *[2024-09-12T11:14:39Z]NoClusters: No clusters in pool are ready to be claimed 
INFO[2024-09-12T12:14:39Z] Releasing cluster claims for test e2e-oncluster-test

@matejvasek
Copy link
Collaborator Author

/test 415-e2e-oncluster-test

@openshift-merge-bot openshift-merge-bot bot merged commit 52eb04f into serverless-1.34 Sep 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@dsimansk dsimansk

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @dsimansk