Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.34] Set default value for REGISTRY param on func-s2i task [SRVOCF-628] #922

Conversation

jrangelramos
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (serverless-1.34@a3e64dd). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.34     #922   +/-   ##
==================================================
  Coverage                   ?   66.65%           
==================================================
  Files                      ?      129           
  Lines                      ?    11936           
  Branches                   ?        0           
==================================================
  Hits                       ?     7956           
  Misses                     ?     3018           
  Partials                   ?      962           
Flag Coverage Δ
e2e-test 37.57% <0.00%> (?)
e2e-test-runtime-go 26.66% <0.00%> (?)
e2e-test-runtime-node 26.05% <0.00%> (?)
e2e-test-runtime-python 26.05% <0.00%> (?)
e2e-test-runtime-quarkus 26.12% <0.00%> (?)
e2e-test-runtime-rust 25.17% <0.00%> (?)
e2e-test-runtime-springboot 25.20% <0.00%> (?)
e2e-test-runtime-typescript 26.13% <0.00%> (?)
integration-tests 53.16% <100.00%> (?)
unit-tests 51.32% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Collaborator

dsimansk commented Oct 3, 2024

/approve
/lgtm

Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,jrangelramos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 25c6d78 into openshift-knative:serverless-1.34 Oct 3, 2024
22 checks passed
@matejvasek matejvasek mentioned this pull request Oct 3, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Oct 4, 2024
* Create test symlinks dynamically

Some tools dislike having questionable symlinks in git repository so we
must create this symlinks dynamically in the test instead of having it
committed into the repository.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>

* fix: Remove unnecesary annotations from Pipeline-as-Code template (#917)

* Set default value for REGISTRY param on func-s2i task (#922)

* fixup: fix size/hash of socat rpm

Signed-off-by: Matej Vašek <matejvasek@gmail.com>

* Fix test failures in OCP prow CI

Ensure that ServeRepo() make copy of repo from ./testdata and serves the
repo from that copy.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>

---------

Signed-off-by: Matej Vašek <matejvasek@gmail.com>

---------

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Co-authored-by: Jefferson Ramos <jrangelramos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants