-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.15] Make array when filters is nil #959
[release-1.15] Make array when filters is nil #959
Conversation
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
/test 417-e2e-oncluster-test |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-v1.15 #959 +/- ##
================================================
Coverage ? 65.09%
================================================
Files ? 129
Lines ? 15399
Branches ? 0
================================================
Hits ? 10024
Misses ? 4406
Partials ? 969
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@matzew: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test 418-e2e-oncluster-test |
/approve |
71fa2f6
into
openshift-knative:release-v1.15
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
same as #958 but for 1.15 (so we have it in 1.35... do we ??)