Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Make array when filters is nil #959

Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 5, 2024

same as #958 but for 1.15 (so we have it in 1.35... do we ??)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@dsimansk dsimansk changed the base branch from konflux/references/release-v1.15 to release-v1.15 November 5, 2024 13:36
@matzew
Copy link
Member Author

matzew commented Nov 5, 2024

/test 417-e2e-oncluster-test

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-v1.15@02eee15). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/subscribe.go 25.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.15     #959   +/-   ##
================================================
  Coverage                 ?   65.09%           
================================================
  Files                    ?      129           
  Lines                    ?    15399           
  Branches                 ?        0           
================================================
  Hits                     ?    10024           
  Misses                   ?     4406           
  Partials                 ?      969           
Flag Coverage Δ
e2e-test 36.93% <0.00%> (?)
e2e-test-runtime-go 26.50% <0.00%> (?)
e2e-test-runtime-node 25.91% <0.00%> (?)
e2e-test-runtime-python 25.91% <0.00%> (?)
e2e-test-runtime-quarkus 26.06% <0.00%> (?)
e2e-test-runtime-rust 25.05% <0.00%> (?)
e2e-test-runtime-springboot 25.11% <0.00%> (?)
e2e-test-runtime-typescript 26.02% <0.00%> (?)
integration-tests 51.94% <25.00%> (?)
unit-tests 50.60% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Nov 6, 2024

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/418-e2e-oncluster-test 5239478 link true /test 418-e2e-oncluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@matejvasek
Copy link
Collaborator

/test 418-e2e-oncluster-test

@matejvasek
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@matejvasek matejvasek merged commit 71fa2f6 into openshift-knative:release-v1.15 Nov 12, 2024
22 of 24 checks passed
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants