Generate catalog for 4.17 with olm.csv.metadata #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzew
reviewed
Nov 12, 2024
| @@ -38,8 +38,15 @@ function generate_catalog { | |||
| add_channel "${catalog_template}" "$channel" "$(metadata.get 'olm.replaces')" | |||
| done < <(metadata.get 'olm.channels.list[*]') | |||
|
|
|||
| level=none | |||
There was a problem hiding this comment.
Yeah.
ᐅ opm alpha render-template basic -h
Generate a file-based catalog from a single 'basic template' file
When FILE is '-' or not provided, the template is read from standard input
Usage:
opm alpha render-template basic basic-template-file [flags]
Flags:
-h, --help help for basic
--migrate-level string Name of the last migration to run (default: none)
The migrator will run all migrations up to and including the selected level.
Available migrators:
- none : do nothing
- bundle-object-to-csv-metadata : migrates bundles' "olm.bundle.object" to "olm.csv.metadata"
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging. As this part is not tested in CI anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors such as this one in Konflux pipeline:
Example: https://console.redhat.com/application-pipeline/workspaces/ocp-serverless/applications/serverless-operator-135-fbc-417/pipelineruns/serverless-index-135-fbc-417-on-pull-request-97tvx
There are already fbc-validation checks in Konflux pipeline that verify that: https://github.com/konflux-ci/build-definitions/blob/main/task/fbc-validation/0.1/USAGE.md#bundle-metadata-in-the-appropriate-format
The catalogs will be re-generated on the next "make generated-files" PR.
Proposed Changes