Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main][SRVKS-1286] Override activator termination grace perio… #3017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[main][SRVKS-1286] Override activator termination grace perio… #3017

wants to merge 1 commit into from
+33 −3

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Nov 12, 2024

@skonto
[RELEASE-1.34][SRVKS-1286] Override activator termination grace period (
f1110ba 
openshift-knative#3011)

* override activator termination grace period

* make generated-files

* restore csv

* use const
@skonto
Copy link
Contributor Author

skonto commented Nov 14, 2024

/test 417-test-upgrade-aws-417

@dsimansk
Copy link
Contributor

/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group cherry-pick-3013-to-main"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-bundle-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group cherry-pick-3013-to-main
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-bundle-135

Only the following failed contexts/checkruns were expected:

  • Generated files are committed
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_override_act_tgp_main
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135
  • Update deps
  • ci/prow/417-images
  • ci/prow/417-operator-e2e-aws-417
  • ci/prow/417-test-upgrade-aws-417
  • ci/prow/417-upstream-e2e-aws-417
  • ci/prow/417-upstream-e2e-kafka-aws-417
  • code/snyk (Hybrid Platforms - OpenShift Serverless)
  • license/snyk (Hybrid Platforms - OpenShift Serverless)
  • pull-ci-openshift-knative-serverless-operator-main-417-images
  • pull-ci-openshift-knative-serverless-operator-main-417-operator-e2e-aws-417
  • pull-ci-openshift-knative-serverless-operator-main-417-test-upgrade-aws-417
  • pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e-aws-417
  • pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e-kafka-aws-417
  • security/snyk (Hybrid Platforms - OpenShift Serverless)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group cherry-pick-3013-to-main"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-bundle-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_override_act_tgp_main"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_override_act_tgp_main, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135

In response to this:

/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_override_act_tgp_main"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@ReToCode
Copy link
Member

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ReToCode,dsimansk,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor

/override "Generated files are committed"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: Generated files are committed

In response to this:

/override "Generated files are committed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr Awaiting requested review from creydr

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dsimansk dsimansk

@ReToCode ReToCode

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skonto @dsimansk @ReToCode