Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kourier v1.11 instead of v1.10 for release-next #413

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

nak3
Copy link

@nak3 nak3 commented Aug 14, 2023

What this PR does / why we need it:

This change knative#14074 requires Kourier 1.11 which includes knative-extensions/net-kourier#1058.
However currently release-next branch uses Kourier v1.10 so we need to tweak until SO repo has kourier v1.11.

Which issue(s) this PR fixes:

NONE as only CI release-next issue.

Does this PR needs for other branches:

No, as release-1.11 branch does not have knative#14074.

Does this PR (patch) needs to update/drop in the future?:

JIRA: https://issues.redhat.com/browse/SRVKS-1112

@nak3
Copy link
Author

nak3 commented Aug 14, 2023

/cc @ReToCode @skonto

This is verified in #408.

There is one issue(vegeta lib issue) remained, but it needs to be fixed on upstream. (#408 reverted the vegeta version up.)

@openshift-ci openshift-ci bot requested a review from skonto August 14, 2023 04:33
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for debugging and fixing this! 🙏

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 50b264c into openshift-knative:main Aug 14, 2023
3 checks passed
ReToCode added a commit to ReToCode/serving that referenced this pull request Jan 8, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants