-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oran o2ims compliance tests playbook #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! much better than the solution we currently have
Should we put the playbook in another sub-directory? I'm a bit confused about the naming here, is this o2ims specific compliance tests or general?
Also, can we add a readme to the roles so it will be clear what it is and what are the requirements?
@natifridman What about if I remnamed it to |
I like the last one |
77f2006
to
dcc630d
Compare
roles/setup_vpn/README.md
Outdated
setup_vpn | ||
========= | ||
|
||
Sets up a percistant openconnect vpn process using tmux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sets up a percistant openconnect vpn process using tmux | |
Sets up a persistent `openconnect` vpn process using tmux |
46cb79f
to
2e78bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added one comment
clone_command: "{{ clone_command }} --branch {{ eco_validation_repo_version }}" | ||
when: eco_validation_repo_version is defined | ||
|
||
- name: Reclone eco-validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to clone it again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think I added this for help with debugging. I'll remove it
2e78bb9
to
8009297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natifridman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.