Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oran o2ims compliance tests playbook #1

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

nocturnalastro
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@natifridman natifridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! much better than the solution we currently have
Should we put the playbook in another sub-directory? I'm a bit confused about the naming here, is this o2ims specific compliance tests or general?

Also, can we add a readme to the roles so it will be clear what it is and what are the requirements?

@nocturnalastro
Copy link
Collaborator Author

nocturnalastro commented Jan 29, 2025

Should we put the playbook in another sub-directory? I'm a bit confused about the naming here, is this o2ims specific compliance tests or general?

@natifridman What about if I remnamed it to run_o2ims_compliance_tests.yml or run_oran_o2ims_compliance_tests.yml

@natifridman
Copy link
Collaborator

@natifridman What about if I remnamed it to run_o2ims_compliance_tests.yml or run_oran_o2ims_compliance_tests.yml

I like the last one

setup_vpn
=========

Sets up a percistant openconnect vpn process using tmux
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sets up a percistant openconnect vpn process using tmux
Sets up a persistent `openconnect` vpn process using tmux

@nocturnalastro nocturnalastro force-pushed the oran-o2ims-complaince branch 2 times, most recently from 46cb79f to 2e78bb9 Compare January 30, 2025 14:34
Copy link
Collaborator

@natifridman natifridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added one comment

clone_command: "{{ clone_command }} --branch {{ eco_validation_repo_version }}"
when: eco_validation_repo_version is defined

- name: Reclone eco-validation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to clone it again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think I added this for help with debugging. I'll remove it

Copy link
Collaborator

@natifridman natifridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
Copy link

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natifridman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 53663dc into main Feb 3, 2025
2 checks passed
@nocturnalastro nocturnalastro deleted the oran-o2ims-complaince branch February 3, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants