Fix mirror config for v6-primary #1699
Conversation
|
/test e2e-metal-ipi-ovn-dualstack-v6 |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test e2e-metal-ipi-ovn-dualstack-v6 I flipped this back to draft because I'm not necessarily expecting it to work yet, but I want to see how it behaves in CI since it has been different from my local results up until now. |
|
/test e2e-metal-ipi-ovn-dualstack-v6 Cluster deployed this time but the job failed on image stream import. Seems unrelated, but let's see if it reproduces. |
openshift-merge-robot
added
the
needs-rebase
cybertron
force-pushed
the
v6-primary-mirror
branch
from
1a50b9c to
19f63d2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
removed
the
needs-rebase
It turns out we do need to mirror images for v6-primary clusters because during provisioning they only get an IP from the primary family, which means they can't pull images from the public ipv4 image registries. This fixes the logic so it is all consistent where it needs to be so v6-primary deployments will work as intended by default.
cybertron
force-pushed
the
v6-primary-mirror
branch
from
19f63d2 to
4c80763
Compare
|
/test e2e-metal-ipi-ovn-dualstack-v6 |
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
It turns out we do need to mirror images for v6-primary clusters because during provisioning they only get an IP from the primary family, which means they can't pull images from the public ipv4 image registries. This fixes the logic so it is all consistent where it needs to be so v6-primary deployments will work as intended by default.