Skip to content

utils: emit disableCertificateVerification for idrac driver#1861

Open
bogdando wants to merge 1 commit intoopenshift-metal3:masterfrom
bogdando:idrac_tls_fix
Open

utils: emit disableCertificateVerification for idrac driver#1861
bogdando wants to merge 1 commit intoopenshift-metal3:masterfrom
bogdando:idrac_tls_fix

Conversation

@bogdando
Copy link

@bogdando bogdando commented Mar 6, 2026

The disableCertificateVerification field in install-config.yaml is only emitted when driver_prefix was "redfish". The idrac driver sets driver_prefix to "drac", so the block was skipped entirely, causing Ironic to verify the BMC's self-signed certificate and fail with SSL: CERTIFICATE_VERIFY_FAILED.

Extend the condition to also cover the "drac" prefix so that redfish_verify_ca from the nodes JSON is honoured for Dell iDRAC hardware.

Generated-By: Cursor (claude-4.6-opus-high)

The disableCertificateVerification field in install-config.yaml is
only emitted when driver_prefix was "redfish". The idrac driver sets
driver_prefix to "drac", so the block was skipped entirely, causing
Ironic to verify the BMC's self-signed certificate and fail with
SSL: CERTIFICATE_VERIFY_FAILED.

Extend the condition to also cover the "drac" prefix so that
redfish_verify_ca from the nodes JSON is honoured for Dell iDRAC
hardware.

Generated-By: Cursor (claude-4.6-opus-high)
Signed-off-by: Bohdan Dobrelia <bdobreli@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tdomnesc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2026

Hi @bogdando. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bogdando
Copy link
Author

bogdando commented Mar 6, 2026

for the record, we need this fix in RHOSO CI for a custom SNO BM setup by dev-scripts, where I could not use Redfish virtual media driver, so tried the idrac one, and hit the subj issue

https://github.com/openstack-k8s-operators/ci-framework/pull/3739/changes#diff-b42c1ffd0e6c247d43022ea34bad373ac33b9135425cd21e87549d0b0196d629R66

@bogdando bogdando marked this pull request as ready for review March 9, 2026 09:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2026
@openshift-ci openshift-ci bot requested review from celebdor and elfosardo March 9, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant