modified kubevirt scripts to use populators #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good from my side. |
|
@elfosardo I could not add reviewers to this PR. Can you review it and possibly merge it if its ok? |
jobbler
changed the title
elfosardo
approved these changes
Dec 16, 2024
| @@ -1,5 +1,5 @@ | |||
| FROM registry.fedoraproject.org/fedora-minimal:40 | |||
| MAINTAINER Mario Vazquez <mavazque@redhat.com> | |||
| MAINTAINER https://github.com/openshift-metal3/fakefish | |||
There was a problem hiding this comment.
this doesn't look like part of this change
There was a problem hiding this comment.
were you wanting this changed back to Mario? I set it to the project since it was updated and did not know if he wanted his name there still. I can change it back if desired. makes no difference to the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the kubevirt scripts to use volume populators