Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make status message as templates #1455

Merged

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Sep 26, 2023

Status message was getting too complicated when managing with fmt.Sprintf and it was getting hard to maintain, changing this to use a more flexible go templates.

And add tkn binary URL for download links in the message

  • how it look like on webhook method (gitea):
    Screenshot_2023-09-26-14:46 50

  • on Github checks run
    Screenshot_2023-09-26-14:47 49

Changes

Submitter Checklist

  • 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
  • ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
  • ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Status message was getting too complicated when managing with
fmt.Sprintf  and it was getting hard to maintain, changing this to use a
more flexible go templates.

And add tkn binary URL for download links in the message

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@@ -61,6 +61,7 @@ const (

var (
TknBinaryName = `tkn`
TknBinaryURL = `https://tekton.dev/docs/cli/#installation`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need to set this to the opc url in downstream @piyush-garg

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (c0fd155) 61.62% compared to head (830f6e6) 61.58%.
Report is 1 commits behind head on main.

❗ Current head 830f6e6 differs from pull request most recent head a064b4f. Consider uploading reports for the commit a064b4f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
- Coverage   61.62%   61.58%   -0.05%     
==========================================
  Files         136      137       +1     
  Lines       10255    10277      +22     
==========================================
+ Hits         6320     6329       +9     
- Misses       3424     3435      +11     
- Partials      511      513       +2     
Files Coverage Δ
pkg/formatting/starting.go 100.00% <100.00%> (ø)
pkg/params/settings/config.go 59.05% <ø> (ø)
pkg/pipelineascode/pipelineascode.go 64.77% <62.50%> (-2.10%) ⬇️
pkg/reconciler/reconciler.go 19.76% <0.00%> (-0.84%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piyush-garg piyush-garg merged commit 9569021 into openshift-pipelines:main Oct 18, 2023
1 check passed
@piyush-garg
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants