Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure E2E test setup on PAC for bitbucket server #1820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zakisk
Copy link
Contributor

@zakisk zakisk commented Nov 12, 2024

configured e2e test for bitbucket server on PAC and wrote one test for pull request.

https://issues.redhat.com/browse/SRVKP-6758

Changes

Submitter Checklist

  • 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (2609b4b) to head (f515e53).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
+ Coverage   65.34%   65.35%   +0.01%     
==========================================
  Files         177      177              
  Lines       13594    13594              
==========================================
+ Hits         8883     8885       +2     
+ Misses       4119     4117       -2     
  Partials      592      592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zakisk zakisk force-pushed the SRVKP-6758 branch 7 times, most recently from cbaa344 to f515e53 Compare November 15, 2024 12:16
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
test/pkg/bitbucketserver/setup.go Show resolved Hide resolved
@zakisk zakisk force-pushed the SRVKP-6758 branch 2 times, most recently from cbb5d04 to b8764c8 Compare January 2, 2025 07:40
configured e2e test for bitbucket server on PAC and
wrote one test for pull request.

https://issues.redhat.com/browse/SRVKP-6758

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
@zakisk
Copy link
Contributor Author

zakisk commented Jan 7, 2025

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants