chore(lint): scope revive var-naming exclusion to specific packages #2347
Conversation
Summary of ChangesHello @theakshaypant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a configuration change to the project's linting setup. Specifically, it disables a variable naming rule within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 PR Lint Feedback
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the revive linter's var-naming rule to avoid conflicts with stdlib package names. While this solves the immediate problem, a more targeted approach would be to configure an allow-list for the rule instead of disabling it entirely. This would preserve the rule's benefits for the rest of the codebase while addressing the specific conflicts. I've added a suggestion to implement this more targeted fix.
Replace global var-naming rule disable with targeted exclusions for packages that conflict with Go stdlib names: pkg/errors, pkg/llm/context, pkg/sort, and pkg/test/http. Signed-off-by: Akshay Pant <akshay.akshaypant@gmail.com>
theakshaypant
force-pushed
the
fix-golangci-revive-var-naming
branch
from
f8727e2 to
e93bf3a
Compare
theakshaypant
changed the title
2 participants
📝 Description of the Change
Replace global var-naming rule disable with targeted exclusions
for packages that conflict with Go stdlib names: pkg/errors,
pkg/llm/context, pkg/sort, and pkg/test/http. This ensures
the linter remains active for other packages.
Refer #2320 (comment)
👨🏻 Linked Jira
N/A
🔗 Linked GitHub Issue
N/A
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.