Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup changes #61

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Minor cleanup changes #61

merged 5 commits into from
Oct 16, 2024

Conversation

dagrayvid
Copy link
Collaborator

No description provided.

config.yaml Outdated
use_tls: False # Use True if querying an SSL grpc endpoint over https
streaming: True
model_name: "flan-t5-small"
host: "route.to.host"
port: 8033
endpoint: "/v1/completions" # for openai plugin
# port: 8033 #
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the port and interface comments since the openai_plugin does not support them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some context to hopefully make it clear that only some plugins require them. WDYT?

@dagrayvid dagrayvid merged commit 044694b into openshift-psap:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants