Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serving: add cluster cleanup code #98

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Conversation

kpouget
Copy link
Contributor

@kpouget kpouget commented Nov 8, 2023

No description provided.

Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kpouget. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-psap openshift-psap deleted a comment from openshift-ci bot Nov 8, 2023
@kpouget
Copy link
Contributor Author

kpouget commented Nov 8, 2023

/test watsonx-serving-light quick e2e_perf cleanup

@kpouget kpouget force-pushed the cleanup branch 2 times, most recently from 3fe0692 to 0fac6dd Compare November 8, 2023 18:51
@kpouget
Copy link
Contributor Author

kpouget commented Nov 8, 2023

/test watsonx-serving-light quick e2e_perf cleanup

@kpouget
Copy link
Contributor Author

kpouget commented Nov 8, 2023

/test watsonx-serving-light quick e2e_perf cleanup

1 similar comment
@kpouget
Copy link
Contributor Author

kpouget commented Nov 8, 2023

/test watsonx-serving-light quick e2e_perf cleanup

@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-light quick e2e_perf cleanup

@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-e2e quick e2e_perf cleanup keep

@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-e2e e2e_perf cleanup keep quick

@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-light e2e_perf cleanup quick

@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-light e2e_perf cleanup quick

1 similar comment
@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-light e2e_perf cleanup quick

@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-light e2e_perf cleanup quick

@kpouget kpouget force-pushed the cleanup branch 2 times, most recently from d51083b to 2c4f223 Compare November 9, 2023 18:10
@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-light e2e_perf cleanup quick

otherwise there might be conficts when running commands in parallel

I'm not sure why NamedTemporaryFile doesn't give truly unique names, but I don't have time to investigate ...
@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

/test watsonx-serving-light e2e_perf cleanup quick

@kpouget
Copy link
Contributor Author

kpouget commented Nov 9, 2023

test passed, all the RHOAI namespaces have been removed \o/

@kpouget kpouget merged commit 7d511b6 into openshift-psap:main Nov 9, 2023
@kpouget kpouget deleted the cleanup branch November 9, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant