NO-ISSUE: Fix linting issues

[pawanpinjarkar]

Fix golangci-lint warnings in agent-tui

Before: make run

tools/agent_tui/ui/controller.go:14:2: field `rendezvousIPSet` is unused (unused)
tools/agent_tui/ui/rendezvous_ip_select.go:29:21: S1039: unnecessary use of fmt.Sprintf (gosimple)
tools/agent_tui/ui/rendezvous_ip_select.go:86:3: ineffectual assignment to currentItem (ineffassign)
tools/agent_tui/ui/rendezvous_ip_select.go:87:3: ineffectual assignment to updatedItemIndex (ineffassign)
tools/agent_tui/ui/rendezvous_ip_select.go:85:3: SA4006: this value of `previousItem` is never used (staticcheck)
tools/agent_tui/ui/rendezvous_ip_connectivity_fail_modal.go:9:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
tools/agent_tui/ui/rendezvous_ip_save_success_modal.go:11:2: SA9004: only the first constant in this group has an explicit type (staticcheck)

After: make run
No issues found

[openshift-ci-robot]

@pawanpinjarkar: This pull request explicitly references no jira issue.

Details

In response to this:

Fix golangci-lint warnings in agent-tui

Before: make run

tools/agent_tui/ui/controller.go:14:2: field `rendezvousIPSet` is unused (unused)
tools/agent_tui/ui/rendezvous_ip_select.go:29:21: S1039: unnecessary use of fmt.Sprintf (gosimple)
tools/agent_tui/ui/rendezvous_ip_select.go:86:3: ineffectual assignment to currentItem (ineffassign)
tools/agent_tui/ui/rendezvous_ip_select.go:87:3: ineffectual assignment to updatedItemIndex (ineffassign)
tools/agent_tui/ui/rendezvous_ip_select.go:85:3: SA4006: this value of `previousItem` is never used (staticcheck)
tools/agent_tui/ui/rendezvous_ip_connectivity_fail_modal.go:9:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
tools/agent_tui/ui/rendezvous_ip_save_success_modal.go:11:2: SA9004: only the first constant in this group has an explicit type (staticcheck)

After: make run
No issues found

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/cc @rwsu @bfournie @andfasano

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pawanpinjarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andfasano]

/lgtm

[bfournie]

Looks like gofmt is failing

--- a/tools/agent_tui/ui/controller.go
+++ b/tools/agent_tui/ui/controller.go
@@ -9,8 +9,8 @@ type Controller struct {
 	ui      *UI
 	channel chan checks.CheckResult
 
-	checks          map[string]checks.CheckResult
-	state           bool
+	checks map[string]checks.CheckResult
+	state  bool
 }

[pawanpinjarkar]

@bfournie I have fixed the gofmt issue. The reason it was not detected when I ran make lint locally is due to gofmt not explicitly enabled. I also see there is no .golangci.yaml file like other repos. I will create a new PR to add that file and fix more lint issues.

[openshift-ci]

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pawanpinjarkar]

/verified by ci/prow/gofmt

[openshift-ci-robot]

@pawanpinjarkar: This PR has been marked as verified by [ci/prow/gofmt](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_agent-installer-utils/255/pull-ci-openshift-agent-installer-utils-main-gofmt/2023442574110363648).

Details

In response to this:

/verified by ci/prow/gofmt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/lgtm