AGENT-1447: Override prefilled rendezvousIP#256
AGENT-1447: Override prefilled rendezvousIP#256pawanpinjarkar wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@pawanpinjarkar: This pull request references AGENT-1447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pawanpinjarkar
force-pushed
the
prefilled-rendezvousIP-tui
branch
2 times, most recently
from
4ae9cbf to
c7dcf5f
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
pawanpinjarkar
force-pushed
the
prefilled-rendezvousIP-tui
branch
from
c7dcf5f to
fe82cf5
Compare
|
@pawanpinjarkar: This pull request references AGENT-1447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
If an user has provided rendezvousIP from the SaaS UI, the TUI will now show that prefilled rendezvousIP and user will have an option to modify it. - Detect interactive mode via sentinel file (/etc/assisted/interactive-ui) - Support prefilled rendezvous IP passed from SaaS UI - Display 20-second timeout when interactive mode has prefilled rendezvous IP - Moved "Configure Network" to the first screen - Enhanced navigation on rendezvous IP page with 4 focusable elements - Added new tests - Added a new Makefile target, `make test` The TUI now handles three distinct flows: 1. Interactive mode + prefilled IP from SaaS UI: Shows timeout with an option to modify the rendezvous IP 2. Interactive mode without IP: Shows rendezvous IP form directly 3. Non-interactive mode: Shows registry check screen (existing behavior) Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
pawanpinjarkar
force-pushed
the
prefilled-rendezvousIP-tui
branch
from
fe82cf5 to
fb43682
Compare
|
/test verify-vendor |
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| u.configureNetworkForm.SetButtonsAlign(tview.AlignRight) | ||
| u.configureNetworkForm.AddButton(RENDEZVOUS_CONFIGURE_NETWORK_BUTTON, func() { | ||
| u.showNMTUIWithErrorDialog(func() { | ||
| u.setFocusToRendezvousIP() |
There was a problem hiding this comment.
After quitting from nmtui, the UI redirects to a page showing the release image checks. It should go back to the rendezvous IP form.
There was a problem hiding this comment.
Screen.Recording.2026-02-19.at.10.16.40.AM.mov
| mainFlex.SetTitle(" Rendezvous node setup "). | ||
| AddItem(u.selectIPForm, 3, 0, false). | ||
| AddItem(separator, 1, 0, false). | ||
| AddItem(u.configureNetworkForm, 3, 0, false) |
There was a problem hiding this comment.
The bottom border is missing.
3 participants
This PR adds support for interactive UI mode in agent-tui, allowing users to override a prefilled rendezvous IP address. When the agent-tui detects it's running in interactive mode with a prefilled IP, it displays a timeout modal giving users the option to modify the IP or quit, with an automatic timeout to proceed with the existing configuration.
To test, run
make test.To test TUI manually on local machine:
sudo touch /etc/assisted/interactive-ui/etc/assisted/rendezvous-host.envmake run- should display timeout modal with prefilled IPmake run- should show rendezvous IP form directly with options to enter rendezvous IP,save rendezvous IPbutton,this is the rendezvous nodebutton and aconfigure networkbuttonmake run- should show usual registry connectivity check screen.