Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale sub resource not autogenerated #2075

Open
enxebre opened this issue Oct 23, 2024 · 1 comment
Open

Scale sub resource not autogenerated #2075

enxebre opened this issue Oct 23, 2024 · 1 comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@enxebre
Copy link
Member

enxebre commented Oct 23, 2024

Scale sub resource seems to not be autogenerated via tool/marker and require manual override
https://github.com/openshift/api/blob/8a37acc9b03ee282ba87accec1c717f3e63808e4/machine/v1/manual-override-crd-manifests/controlplanemachinesets.machine.openshift.io/SelfManagedHA.yaml
enxebre added a commit to enxebre/hypershift that referenced this issue Oct 23, 2024
@enxebre
Add crd override for NodePool scale subresource
8021723 
While this should be generated by the tooling/marker, it's not atm openshift/api#2075. This fixes the regression while the tooling is fixed
@enxebre enxebre mentioned this issue Oct 23, 2024
Merged
4 tasks
haircommander pushed a commit to haircommander/hypershift that referenced this issue Oct 29, 2024
@enxebre @haircommander
Add crd override for NodePool scale subresource
6bb48c5 
While this should be generated by the tooling/marker, it's not atm openshift/api#2075. This fixes the regression while the tooling is fixed
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enxebre @openshift-bot