OCPBUGS-64929: coreos-installer iso kargs show broken on OVE Agent ISO#656
Conversation
Vendor latest assisted-image-service commit 503834119b3e
|
@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-64929, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-64929, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.21, release-4.20 |
|
@pawanpinjarkar: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @zaneb @danielerez |
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez, pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pawanpinjarkar: Jira Issue OCPBUGS-64929: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-64929 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pawanpinjarkar: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.21 |
|
@pawanpinjarkar: #656 failed to apply on top of branch "release-4.21": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| github.com/pelletier/go-toml v1.9.5 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/sirupsen/logrus v1.9.4-0.20251023124752-b61f268f75b6 | ||
| github.com/sirupsen/logrus v1.9.4 |
There was a problem hiding this comment.
Looks like we dropped the change from #580, but I'm unclear on the significance of that.
There was a problem hiding this comment.
I discussed with @danielerez. As suggested, its not crucial, the konflux bot should handle it again.
Vendor latest assisted-image-service commit 503834119b3e. This fixes broken
iso kargs showresults.