MGMT-20023: Route inventory deleted when route without next hop interface

[rivkyrizel]

Before this fix, if a node had a special route like route add -host 64.1.2.3 reject, the agent failed to get the route’s link name and stopped collecting any routes.
This resulted in an empty route list in the inventory and caused the host to fail validation.
Now, if one route causes an error, we log it and skip it. so the rest of the routes are still collected correctly.

[openshift-ci-robot]

@rivkyrizel: This pull request references MGMT-20023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Before this fix, if a node had a special route like route add -host 64.1.2.3 reject, the agent failed to get the route’s link name and stopped collecting any routes. This resulted in an empty route list in the inventory and caused the host to fail validation. Now, if one route causes an error, we log it and skip itץ
so the rest of the routes are still collected correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rivkyrizel: This pull request references MGMT-20023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Before this fix, if a node had a special route like route add -host 64.1.2.3 reject, the agent failed to get the route’s link name and stopped collecting any routes. This resulted in an empty route list in the inventory and caused the host to fail validation. Now, if one route causes an error, we log it and skip itץ
so the rest of the routes are still collected correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rivkyrizel: This pull request references MGMT-20023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Before this fix, if a node had a special route like route add -host 64.1.2.3 reject, the agent failed to get the route’s link name and stopped collecting any routes. This resulted in an empty route list in the inventory and caused the host to fail validation. Now, if one route causes an error, we log it and skip it.
so the rest of the routes are still collected correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rivkyrizel: This pull request references MGMT-20023 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Before this fix, if a node had a special route like route add -host 64.1.2.3 reject, the agent failed to get the route’s link name and stopped collecting any routes.
This resulted in an empty route list in the inventory and caused the host to fail validation.
Now, if one route causes an error, we log it and skip it. so the rest of the routes are still collected correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rivkyrizel]

/cc @eliorerz @gamli75

[rivkyrizel]

/uncc @jhernand @omertuc

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.17%. Comparing base (36de72b) to head (307b6e8).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   60.21%   60.17%   -0.04%     
==========================================
  Files          75       75              
  Lines        4044     4050       +6     
==========================================
+ Hits         2435     2437       +2     
- Misses       1432     1437       +5     
+ Partials      177      176       -1     

Files with missing lines	Coverage Δ
src/inventory/routes.go	57.14% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[eliorerz]

Look good, I think that we might want to add a UT that check the case that was before (except error) and the case now (except pass)

[eliorerz]

LGTM

[openshift-ci-robot]

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed parameter:
/test edge-e2e-ai-operator-ztp
/test edge-e2e-metal-assisted-4-19

[eliorerz]

/test okd-scos-e2e-aws-ovn

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d19761e and 2 for PR HEAD a165468 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d19761e and 2 for PR HEAD a165468 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d19761e and 2 for PR HEAD a165468 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d19761e and 2 for PR HEAD a165468 in total

[rivkyrizel]

/retest

[rivkyrizel]

/retest

[gamli75]

/override ci/prow/okd-scos-e2e-aws-ovn

[openshift-ci]

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/okd-scos-e2e-aws-ovn

In response to this:

/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gamli75]

/retest

[rivkyrizel]

/retest

[gamli75]

/retest

[rivkyrizel]

/retest

[eliorerz]

LGTM

[openshift-ci-robot]

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed parameter:
/test edge-e2e-ai-operator-ztp
/test edge-e2e-metal-assisted-4-19

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, rivkyrizel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [eliorerz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cbe413e and 2 for PR HEAD 307b6e8 in total

[rivkyrizel]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cbe413e and 2 for PR HEAD 307b6e8 in total

[openshift-ci]

@rivkyrizel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-node-agent
This PR has been included in build ose-agent-installer-node-agent-container-v4.20.0-202506301643.p0.g45967dc.assembly.stream.el9.
All builds following this will include this PR.