capiinstaller: drop manager replacement

[damdo]

capiinstaller drop manager replacement
Needs to be green button merged (a.k.a. "flag day" ed), together with:

• UPSTREAM: <carry>: openshift: rename manager binary cluster-api#252
• UPSTREAM: <carry>: openshift: rename manager binary cluster-api-provider-aws#581
• UPSTREAM: <carry>: openshift: rename manager binary cluster-api-provider-gcp#252
• UPSTREAM: <carry>: openshift: rename manager binary cluster-api-provider-ibmcloud#132

Summary by CodeRabbit

• Refactor
  • Simplified manifest processing by removing provider-specific command customization. Manifests will now use the default manager command path instead of provider-specific variants.

[openshift-ci-robot]

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger optional jobs most likely to be impacted by the proposed changes.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Walkthrough

The changes remove provider-specific command customization logic from the CAPI installer. A helper function providerNameToCommand is deleted from the customizer, and the corresponding manifest command substitution step is removed from the controller, allowing manifests to retain their literal "/manager" path.

Changes

Cohort / File(s)	Summary
Provider command customization removal pkg/controllers/capiinstaller/capi_installer_controller.go, pkg/controllers/capiinstaller/component_customizer.go	Deleted providerNameToCommand() function and removed manifest-level command path substitution during provider manifest extraction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Both changes are straightforward deletions with no new logic introduced
• Verify that removing the command substitution doesn't break any provider-specific deployment requirements
• Confirm that retained "/manager" literal path is intentional across all providers

Poem

🐰 A command was removed with a gentle hop,
No more swaps at the manager stop,
Providers now keep their paths clean,
The simplest refactor we've seen!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'capiinstaller: drop manager replacement' directly and clearly describes the main change: removing the manager replacement logic from the capiinstaller, which aligns perfectly with the file-level summaries showing removal of manager command substitution.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 5f7410a and ba32a78.

📒 Files selected for processing (2)

• pkg/controllers/capiinstaller/capi_installer_controller.go (0 hunks)
• pkg/controllers/capiinstaller/component_customizer.go (0 hunks)

💤 Files with no reviewable changes (2)

• pkg/controllers/capiinstaller/component_customizer.go
• pkg/controllers/capiinstaller/capi_installer_controller.go

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign racheljpg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.