Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-1086: Bump openshift/api #312

Closed
wants to merge 2 commits into from
Closed

CFE-1086: Bump openshift/api #312

wants to merge 2 commits into from

Conversation

chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Jun 26, 2024 •
edited
Loading

This PR

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2024
@chiragkyal chiragkyal marked this pull request as ready for review June 27, 2024 07:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024
@openshift-ci openshift-ci bot requested review from nrb and theobarberbany June 27, 2024 07:14
@chiragkyal
Bump openshift/api,openshift/client-go
c90d1a1 
Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal
react on client-go changes for applyConfiguration
a5aa2b9 
Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

@chiragkyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit a5aa2b9 link true /test unit
ci/prow/e2e-azure-operator a5aa2b9 link false /test e2e-azure-operator
ci/prow/e2e-aws-ovn-etcd-scaling a5aa2b9 link true /test e2e-aws-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chiragkyal chiragkyal changed the title Bump openshift/api CFE-1086: Bump openshift/api Jun 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 27, 2024 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references CFE-1086 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 27, 2024 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references CFE-1086 which is a valid jira issue.

In response to this:

This PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chiragkyal
Copy link
Member Author

/assign @JoelSpeed

@chiragkyal
Copy link
Member Author

@JoelSpeed, I think we don't have to update the validation as we did for openshift/machine-api-operator#1242

@JoelSpeed
Copy link
Contributor

Somehow this PR has caused panics across the test suite, can you please look into why they're suddenly going wrong?

@chiragkyal
Copy link
Member Author

/hold
Looks like a similar PR is already approved #313

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2024
@chiragkyal
Copy link
Member Author

API bump already landed through #313
/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Jul 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

@chiragkyal: Closed this PR.

In response to this:

API bump already landed through #313
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chiragkyal chiragkyal deleted the partition-number branch July 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb Awaiting requested review from nrb

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@JoelSpeed JoelSpeed

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chiragkyal @openshift-ci-robot @JoelSpeed @openshift-merge-robot