-
Couldn't load subscription status.
- Fork 255
Update ClusterDeployment docs #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
`machineNetwork` has been an array instead of a string since 4.16; see [blame](https://github.com/openshift/installer/blame/release-4.19/pkg/types/installconfig.go#L393) for more info. Signed-off-by: Carlos Nunez <cnunez@redhat.com>
Signed-off-by: Carlos Nunez <cnunez@redhat.com>
Signed-off-by: Carlos Nunez <cnunez@redhat.com>
|
Hi @carlosonunez-redhat. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Thanks for these updates! A couple of minor adjustments suggested inline.
|
I'll also note that hive needs to support all live versions of OCP, and you have to supply an install-config.yaml of the appropriate shape for the version you're installing, and I think we're still supporting some versions that would accept the install-config shape prior to your changes. However, it's a good look to use the latest and greatest as our example, so still +1 to this change. |
Co-authored-by: Eric Fried <2uasimojo@users.noreply.github.com>
Co-authored-by: Eric Fried <2uasimojo@users.noreply.github.com>
|
@2uasimojo : Happy to supply the install-config. Where should I provide it? |
Not necessary. I may not have explained myself well. I just meant that the old install-config example may not have been actually wrong if you were installing, say, 4.14. But I agree it's better for our example to reflect a more modern version, so your updates are appropriate. Thanks for your contribution! /lgtm /hold until #2770 merges so we don't retrigger its CI jobs :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, carlosonunez-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ah, okay. This was on 4.18.26, so not _quite_ latest and greatest, but not
in EUS yet either :)
…On Mon, Oct 27, 2025 at 4:11 PM Eric Fried ***@***.***> wrote:
*2uasimojo* left a comment (openshift/hive#2773)
<#2773 (comment)>
@2uasimojo <https://github.com/2uasimojo> : Happy to supply the
install-config. Where should I provide it?
Not necessary. I may not have explained myself well. I just meant that the
old install-config example may not have been actually wrong if you were
installing, say, 4.14. But I agree it's better for our example to reflect a
more modern version, so your updates are appropriate.
Thanks for your contribution!
/lgtm
/hold until #2770 <#2770> merges so
we don't retrigger its CI jobs :)
—
Reply to this email directly, view it on GitHub
<#2773 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BOLNLVXGVVWPHETLNFIAZ633Z2C6NAVCNFSM6AAAAACKGW3X4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJTGM2TEMBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
/hold cancel |
The
InstallConfigprovided in theClusterDeploymentsection was out-of-date.I got several errors upon trying to provision an AWS cluster from it, but
succeeded after making the changes in this pull request.
This commit includes the following documentation updates:
Updates
machineNetworkto the newtypes.MachineNetworkarray as perthis blame
Clarifies that the
pullSecretshould be a refernece to the name of theKubernetes secret containing the pull secret that is created earlier in the
doc.
Updates the
networkTypetoOVNKubernetes, asOpenShiftSDNis deprecated.