Skip to content

Conversation

@carlosonunez-redhat
Copy link

The InstallConfig provided in the ClusterDeployment section was out-of-date.
I got several errors upon trying to provision an AWS cluster from it, but
succeeded after making the changes in this pull request.

This commit includes the following documentation updates:

  • Updates machineNetwork to the new types.MachineNetwork array as per
    this blame

  • Clarifies that the pullSecret should be a refernece to the name of the
    Kubernetes secret containing the pull secret that is created earlier in the
    doc.

  • Updates the networkType to OVNKubernetes, as OpenShiftSDN is deprecated.

`machineNetwork` has been an array instead of a string since 4.16; see
[blame](https://github.com/openshift/installer/blame/release-4.19/pkg/types/installconfig.go#L393)
for more info.

Signed-off-by: Carlos Nunez <cnunez@redhat.com>
Signed-off-by: Carlos Nunez <cnunez@redhat.com>
Signed-off-by: Carlos Nunez <cnunez@redhat.com>
@openshift-ci openshift-ci bot requested review from jstuever and suhanime October 25, 2025 21:23
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2025

Hi @carlosonunez-redhat. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Thanks for these updates! A couple of minor adjustments suggested inline.

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2025
@2uasimojo
Copy link
Member

I'll also note that hive needs to support all live versions of OCP, and you have to supply an install-config.yaml of the appropriate shape for the version you're installing, and I think we're still supporting some versions that would accept the install-config shape prior to your changes. However, it's a good look to use the latest and greatest as our example, so still +1 to this change.

carlosonunez-redhat and others added 2 commits October 27, 2025 16:03
Co-authored-by: Eric Fried <2uasimojo@users.noreply.github.com>
Co-authored-by: Eric Fried <2uasimojo@users.noreply.github.com>
@carlosonunez-redhat
Copy link
Author

@2uasimojo : Happy to supply the install-config. Where should I provide it?

@2uasimojo
Copy link
Member

@2uasimojo : Happy to supply the install-config. Where should I provide it?

Not necessary. I may not have explained myself well. I just meant that the old install-config example may not have been actually wrong if you were installing, say, 4.14. But I agree it's better for our example to reflect a more modern version, so your updates are appropriate.

Thanks for your contribution!

/lgtm

/hold until #2770 merges so we don't retrigger its CI jobs :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, carlosonunez-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
@carlosonunez-redhat
Copy link
Author

carlosonunez-redhat commented Oct 27, 2025 via email

@2uasimojo
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants