OCPEDGE-2383: feat: update sno minimum to 4vcpu

[eggfoobar]

This lowers the CPU min for SNO to 4vCPU, this allows for deployment in scenarios where smaller computer is required for edge deployments. Utilized with Capabilities this gives users more flexibility with deployments.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rwsu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• data/data/agent/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/retest-required

[eggfoobar]

/retest-required

[eggfoobar]

/retest

[openshift-ci]

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-two-node-fencing-ipv4	ad3f21e	link	false	/test e2e-agent-two-node-fencing-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@eggfoobar: This pull request references OCPEDGE-2383 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@eggfoobar: This pull request references OCPEDGE-2383 which is a valid jira issue.

Details

In response to this:

This lowers the CPU min for SNO to 4vCPU, this allows for deployment in scenarios where smaller computer is required for edge deployments. Utilized with Capabilities this gives users more flexibility with deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/lgtm

[eggfoobar]

/verified by @eggfoobar

Verified locally with an ABI cluster stood up via dev-scripts using profile SNOMIN_IPV4

$ oc get nodes -ojson | jq '.items[].status.capacity'
{
  "cpu": "4",
  "ephemeral-storage": "104266732Ki",
  "hugepages-1Gi": "0",
  "hugepages-2Mi": "0",
  "memory": "32858348Ki",
  "pods": "250"
}

[openshift-ci-robot]

@eggfoobar: This PR has been marked as verified by @eggfoobar.

Details

In response to this:

/verified by @eggfoobar

Verified locally with an ABI cluster stood up via dev-scripts using profile SNOMIN_IPV4

$ oc get nodes -ojson | jq '.items[].status.capacity'
{
 "cpu": "4",
 "ephemeral-storage": "104266732Ki",
 "hugepages-1Gi": "0",
 "hugepages-2Mi": "0",
 "memory": "32858348Ki",
 "pods": "250"
}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andfasano]

/verified by @eggfoobar

Verified locally with an ABI cluster stood up via dev-scripts using profile SNOMIN_IPV4

$ oc get nodes -ojson | jq '.items[].status.capacity'
{
  "cpu": "4",
  "ephemeral-storage": "104266732Ki",
  "hugepages-1Gi": "0",
  "hugepages-2Mi": "0",
  "memory": "32858348Ki",
  "pods": "250"
}

I don't know what is the SNOMIN_IPV4 profile? There is a dedicate CI job for SNO in this repo to verify such kind of patches, it's ci/prow/e2e-agent-sno-ipv6, could you please use the same config for the local test?

Note that the current SNO job is passing, that's because is clearly providing more resources than required (8 VCPU). Since this patch address a general config I'd prefer to have the related official job in sync as well, could you please open also a new PR in dev-scripts to update such value (you can use the same jira card as a reference)? Thanks

Important note: dev-scripts is not versioned, that means that the same config will be used regardless of the underlying OCP version. This means that the ds patch should take into account the version where the new requirement was introduced, and apply only if OCP vers is >= 4.22.
For that you could use the openshift_version function - already adopted for such kind of versions check

[eggfoobar]

Hey @andfasano sounds good,

I had verified this locally with the new SNOMIIN_IPV4 using

export AGENT_E2E_TEST_SCENARIO=SNOMIN_IPV4

I went ahead and did it again with the suggested params

export AGENT_E2E_TEST_SCENARIO=SNOMIN_IPV6
export AGENT_USE_ZTP_MANIFESTS=true
export OPENSHIFT_VERSION=4.22
...
oc get nodes -ojson | jq '.items[].status.capacity'
{
  "cpu": "4",
  "ephemeral-storage": "104266732Ki",
  "hugepages-1Gi": "0",
  "hugepages-2Mi": "0",
  "memory": "32858348Ki",
  "pods": "250"
}

I also went ahead and made the versioning check modification you suggested to the SNOMIN profile, that PR is here openshift-metal3/dev-scripts#1858