Fixups for failed machines on HCP

[elmiko]

while doing some fixing for OCPBUGS-11115, i noticed a condition whereby HCP would not properly detect failed machines. this change makes the logic more aware to differences between MAPI and CAPI.

[elmiko]

/hold

this needs to wait for #347

[elmiko]

i've rebased this, but i wonder if we shouldn't wait for the rebase on upstream so that we can drop one of the commits.

edit: nvm about waiting, we already brought in the upstream patch.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/clusterapi/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@elmiko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-periodic-pre	c3ba40e	link	false	/test e2e-azure-periodic-pre
ci/prow/okd-scos-images	c3ba40e	link	true	/test okd-scos-images
ci/prow/security	ec6d1fd	link	true	/test security
ci/prow/golint	ec6d1fd	link	true	/test golint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[elmiko]

/unhold

[elmiko]

i have a feeling this will need a cleanup, but we should consider adding this for improved hypershift performance.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.