Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]OCPBUGS-37706: Modern TLS security profile support #2071

Closed

Conversation

wangke19
Copy link

@wangke19 wangke19 commented Sep 2, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 2, 2024
@openshift-ci-robot
Copy link

@wangke19: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2024
@openshift-ci openshift-ci bot requested review from deads2k and jerpeter1 September 2, 2024 16:06
Copy link

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangke19
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangke19 wangke19 force-pushed the modern-tlsprofile-support branch from 833c0c2 to eea8646 Compare September 3, 2024 12:09
@openshift-ci-robot
Copy link

@wangke19: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@wangke19: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@wangke19 wangke19 changed the title [WIP]Support modern TLS security Profile [WIP]OCPBUGS-37706: Support modern TLS security Profile Oct 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 24, 2024
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-37706, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Author

/jira refersh

@wangke19 wangke19 force-pushed the modern-tlsprofile-support branch from e120bdc to 3d5da06 Compare October 24, 2024 08:33
@openshift-ci-robot
Copy link

@wangke19: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 24, 2024
@wangke19 wangke19 changed the title [WIP]OCPBUGS-37706: Support modern TLS security Profile [WIP]OCPBUGS-37706: Modern TLS security profile support Oct 24, 2024
@wangke19 wangke19 force-pushed the modern-tlsprofile-support branch from 3d5da06 to aea610c Compare October 30, 2024 08:46
@openshift-ci-robot
Copy link

@wangke19: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Copy link

openshift-ci bot commented Oct 30, 2024

@wangke19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp aea610c link true /test e2e-gcp
ci/prow/e2e-aws-ovn-runc aea610c link true /test e2e-aws-ovn-runc
ci/prow/artifacts aea610c link true /test artifacts
ci/prow/e2e-gcp-ovn-upgrade aea610c link true /test e2e-gcp-ovn-upgrade
ci/prow/integration aea610c link true /test integration
ci/prow/k8s-e2e-gcp-ovn aea610c link true /test k8s-e2e-gcp-ovn
ci/prow/images aea610c link true /test images
ci/prow/unit aea610c link true /test unit
ci/prow/e2e-aws-ovn-cgroupsv2 aea610c link true /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-agnostic-ovn-cmd aea610c link false /test e2e-agnostic-ovn-cmd
ci/prow/k8s-e2e-aws-ovn-serial aea610c link false /test k8s-e2e-aws-ovn-serial
ci/prow/e2e-aws-crun-wasm aea610c link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-serial aea610c link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-fips aea610c link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-crun aea610c link true /test e2e-aws-ovn-crun
ci/prow/verify-commits aea610c link true /test verify-commits
ci/prow/k8s-e2e-conformance-aws aea610c link true /test k8s-e2e-conformance-aws
ci/prow/verify aea610c link true /test verify
ci/prow/k8s-e2e-gcp-serial aea610c link true /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-csi aea610c link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wangke19
Copy link
Author

wangke19 commented Nov 12, 2024

Thist will be implemented in pr openshift/api#2069

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19 wangke19 closed this Nov 12, 2024
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-37706. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Nov 12, 2024

@wangke19: Closed this PR.

In response to this:

Thist will be implemented in pr openshift/api#2069
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants