-
Notifications
You must be signed in to change notification settings - Fork 125
[WIP] enable DRA by default in 4.20 #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
Changes from all commits
c123b3e
209d138
a8428b6
b77cff9
2a90fef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1164,7 +1164,7 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate | |
|
||
DynamicResourceAllocation: { | ||
{Version: version.MustParse("1.26"), Default: false, PreRelease: featuregate.Alpha}, | ||
{Version: version.MustParse("1.32"), Default: false, PreRelease: featuregate.Beta}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought we didn't need this piece if we have the o/api pieces, because the cluster config operator will configure the feature gates enabled in the default set |
||
{Version: version.MustParse("1.32"), Default: true, PreRelease: featuregate.Beta}, | ||
}, | ||
|
||
KubeletCrashLoopBackOffMax: { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ func appendCSIImageConfigs(configs map[ImageID]Config) { | |
} | ||
} | ||
|
||
err := fs.WalkDir(embeddedFS, "storage-csi", func(path string, d fs.DirEntry, err error) error { | ||
walkDirFn := func(path string, d fs.DirEntry, err error) error { | ||
if err != nil { | ||
return err | ||
} | ||
|
@@ -97,10 +97,13 @@ func appendCSIImageConfigs(configs map[ImageID]Config) { | |
|
||
} | ||
return nil | ||
} | ||
|
||
}) | ||
if err != nil { | ||
panic(err) | ||
for _, dir := range []string{"storage-csi"} { | ||
err := fs.WalkDir(embeddedFS, dir, walkDirFn) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not using walkDirFn ? |
||
if err != nil { | ||
panic(fmt.Errorf("error while extracting CSI image configs from directory: %q - %w", dir, err)) | ||
} | ||
} | ||
} | ||
|
||
|
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: conformance*