-
Notifications
You must be signed in to change notification settings - Fork 125
Remove some unnecessary sig-network test skips #2476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6cba674
to
4b12cbb
Compare
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
The ClusterDns and Firewall tests no longer exist. The Topology Hints test was renamed (`[Feature:Topology Hints]` went away when the feature became GA), and we already have a separate skip rule for the new name. The two service tests that were skipped because they require SSH got rewritten at some point to use a HostNetwork pod instead.
4b12cbb
to
dc526f2
Compare
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The ClusterDns and Firewall tests no longer exist.
The Topology Hints test was renamed (
[Feature:Topology Hints]
wentaway when the feature became GA), and we already have a separate skip
rule for the new name.
The two service tests that were skipped because they require SSH got
rewritten at some point to use a HostNetwork pod instead. EDIT: However, one of them now fails for a different reason. Sigh.