Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-1064: Add support for PlacementGroupPartition of placement group #101

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented May 19, 2024

Related to https://issues.redhat.com/browse/CFE-1064

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2024
Copy link
Contributor

openshift-ci bot commented May 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@chiragkyal
Copy link
Member Author

/test all

1 similar comment
@chiragkyal
Copy link
Member Author

/test all

@chiragkyal
Copy link
Member Author

/retest

Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal
Copy link
Member Author

/test all

Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal chiragkyal changed the title [WIP] Add support for PlacementGroupPartition of placement group Add support for PlacementGroupPartition of placement group Jun 26, 2024
@chiragkyal chiragkyal marked this pull request as ready for review June 26, 2024 11:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@chiragkyal chiragkyal changed the title Add support for PlacementGroupPartition of placement group CFE-1064: Add support for PlacementGroupPartition of placement group Jun 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 26, 2024

@chiragkyal: This pull request references CFE-1064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

[WIP] Add support for PlacementGroupPartition of placement group
API: openshift/api#1897

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2024
@openshift-ci openshift-ci bot requested review from elmiko and RadekManak June 26, 2024 11:28
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 26, 2024

@chiragkyal: This pull request references CFE-1064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/CFE-1064

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal
Copy link
Member Author

/assign @JoelSpeed

@chiragkyal
Copy link
Member Author

/cc @huali9
for pre-merge testing

@openshift-ci openshift-ci bot requested a review from huali9 June 26, 2024 15:15
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a97f8aa and 2 for PR HEAD 4491fd5 in total

@chiragkyal
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9bbaca9 into openshift:main Jun 26, 2024
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-provider-aws-container-v4.17.0-202406262328.p0.g9bbaca9.assembly.stream.el9 for distgit ose-machine-api-provider-aws.
All builds following this will include this PR.

@chiragkyal chiragkyal deleted the partition-number branch June 27, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants