docs: Directories and links aren't supported #568
Conversation
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/XS
|
/hold more to this |
openshift-ci-robot
added
the
do-not-merge/hold
Reported by QE. Now separately we seemed not to fail trying to do this for some reason; will investigate that. Move the things we do support to the top for clarity.
cgwalters
changed the title
|
https://github.com/openshift/machine-config-operator/blob/master/docs/MachineConfigDaemon.md#supported-vs-unsupported-ignition-config-changes |
|
Related: #328 |
|
Yep, I updated this to mark links as unsupported too. IOW just files and systemd units are supported. |
|
/approve |
|
good catch @cgwalters /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
is this good to go? still has a hold on it. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
It looks like the doc based on which I reported this issue is now updated to have the directories and links not supported. Does that mean that this PR will be closed and will not make it? @cgwalters @jlebon |
|
I don't quite understand, which doc are you talking about? Do you see something wrong with the code/docs in this repo? |
|
I'm referencing the table in [1] which lists the supported vs unsupported. Last week it used to say |
|
@schituku we have updated the table to accurately reflect what is supported. The current chart is the canonical status of our ignition support. Please use that table and its contents going forward. |
Reported by QE. Now separately we seemed not to fail trying to
do this for some reason; will investigate that.