-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.15 - OADP-4883: Added 1.4.3 release notes #88904
4.15 - OADP-4883: Added 1.4.3 release notes #88904
Conversation
Signed-off-by: A.Arnold <anarnold@redhat.com>
@anarnold97: This pull request references OADP-4883 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@anarnold97: This pull request references OADP-4883 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label oadp |
@anarnold97: This pull request references OADP-4883 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Wed Feb 19 19:56:47 - Prow CI generated the docs preview: |
@anarnold97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@anarnold97: This pull request references OADP-4883 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label merge-review-needed |
@anarnold97: This pull request references OADP-4883 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Maybe consider adding the release date in future release notes as a helpful piece of information for customers.
/label peer-review-done |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cherry picked
REASON
This PR is a copy of OADP-4883: Added 1.4.3 release notes #87964
This PR was accidentally merged before a delayed GA.
OADP 1.4.3 was shipped live this morning
JIRA
VERSIONS
PREVIEW
Link to docs preview: OADP 1.4.3 release notes
QE review:
Meld diff check
Validated by Ben Hardesty - Hi Andy - I added this conditional for ROSA, so it wouldn't have been applied to any branches previous to 4.17. I don't think it would hurt to add the block to 4.15, but it wouldn't be necessary since the ROSA docs are versionless (they're built from the current OCP version number, which would be 4.17). Alternatively, you could simply ignore that conditional for 4.15 since, again, it won't affect the ROSA docs.
All that to say, to resolve this merge conflict, you should be fine either accepting the incoming or the current since it involves an older OpenShift version that isn't published for ROSA.