Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.15 - OADP-4883: Added 1.4.3 release notes #88904

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Feb 19, 2025

Cherry picked

REASON

JIRA

VERSIONS

  • OCP 4.15

PREVIEW

Link to docs preview: OADP 1.4.3 release notes

QE review:

Meld diff check

image

Validated by Ben Hardesty - Hi Andy - I added this conditional for ROSA, so it wouldn't have been applied to any branches previous to 4.17. I don't think it would hurt to add the block to 4.15, but it wouldn't be necessary since the ROSA docs are versionless (they're built from the current OCP version number, which would be 4.17). Alternatively, you could simply ignore that conditional for 4.15 since, again, it won't affect the ROSA docs.
All that to say, to resolve this merge conflict, you should be fine either accepting the incoming or the current since it involves an older OpenShift version that isn't published for ROSA.

Signed-off-by: A.Arnold <anarnold@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@anarnold97: This pull request references OADP-4883 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@anarnold97: This pull request references OADP-4883 which is a valid jira issue.

In response to this:

Cherry picked

REASON

JIRA

VERSIONS

  • OCP 4.14

PREVIEW

Link to docs preview: OADP 1.4.3 release notes

QE review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Feb 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@anarnold97: This pull request references OADP-4883 which is a valid jira issue.

In response to this:

Cherry picked

REASON

JIRA

VERSIONS

  • OCP 4.14

PREVIEW

Link to docs preview: OADP 1.4.3 release notes

QE review:

Meld diff check

image

Validated by Ben Hardesty - Hi Andy - I added this conditional for ROSA, so it wouldn't have been applied to any branches previous to 4.17. I don't think it would hurt to add the block to 4.15, but it wouldn't be necessary since the ROSA docs are versionless (they're built from the current OCP version number, which would be 4.17). Alternatively, you could simply ignore that conditional for 4.15 since, again, it won't affect the ROSA docs.
All that to say, to resolve this merge conflict, you should be fine either accepting the incoming or the current since it involves an older OpenShift version that isn't published for ROSA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Feb 19, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@anarnold97: This pull request references OADP-4883 which is a valid jira issue.

In response to this:

Cherry picked

REASON

JIRA

VERSIONS

  • OCP 4.14

PREVIEW

Link to docs preview: OADP 1.4.3 release notes

QE review:

Meld diff check

image

Validated by Ben Hardesty - Hi Andy - I added this conditional for ROSA, so it wouldn't have been applied to any branches previous to 4.17. I don't think it would hurt to add the block to 4.15, but it wouldn't be necessary since the ROSA docs are versionless (they're built from the current OCP version number, which would be 4.17). Alternatively, you could simply ignore that conditional for 4.15 since, again, it won't affect the ROSA docs.
All that to say, to resolve this merge conflict, you should be fine either accepting the incoming or the current since it involves an older OpenShift version that isn't published for ROSA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@anarnold97: This pull request references OADP-4883 which is a valid jira issue.

In response to this:

Cherry picked

REASON

JIRA

VERSIONS

  • OCP 4.15

PREVIEW

Link to docs preview: OADP 1.4.3 release notes

QE review:

Meld diff check

image

Validated by Ben Hardesty - Hi Andy - I added this conditional for ROSA, so it wouldn't have been applied to any branches previous to 4.17. I don't think it would hurt to add the block to 4.15, but it wouldn't be necessary since the ROSA docs are versionless (they're built from the current OCP version number, which would be 4.17). Alternatively, you could simply ignore that conditional for 4.15 since, again, it won't affect the ROSA docs.
All that to say, to resolve this merge conflict, you should be fine either accepting the incoming or the current since it involves an older OpenShift version that isn't published for ROSA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 19, 2025
@stevsmit stevsmit added this to the Continuous Release milestone Feb 19, 2025
@stevsmit stevsmit added peer-review-needed Signifies that the peer review team needs to review this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Feb 19, 2025
@cbippley
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 19, 2025
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe consider adding the release date in future release notes as a helpful piece of information for customers.

@cbippley
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 19, 2025
@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 19, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 20, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xenolinux xenolinux merged commit 835fd93 into openshift:enterprise-4.15 Feb 20, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants