Skip to content

TELCODOCS-2537 Egress documentation not clear #99999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

TELCODOCS-2537 Egress documentation not clear #99999

merged 1 commit into from
Nov 7, 2025
+115 −47

Conversation

@kquinn1204
Copy link
Contributor

@kquinn1204 kquinn1204 commented Oct 3, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 3, 2025 •
edited
Loading

🤖 Wed Nov 05 13:08:10 - Prow CI generated the docs preview:

https://99999--ocpdocs-pr.netlify.app/
https://99999--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.html
https://99999--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.html

@kquinn1204 kquinn1204 changed the title TELCODOCS-2477 TELCODOCS-2537 Egress documentation not clear Oct 6, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
cgoncalves
cgoncalves reviewed Oct 24, 2025
View reviewed changes
networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.adoc Outdated
Comment on lines 48 to 51
ifndef::openshift-rosa,openshift-rosa-hcp[]
// The egressIPConfig object
include::modules/nw-egress-ips-config-object.adoc[leveloffset=+1]
endif::openshift-rosa,openshift-rosa-hcp[]
Copy link
Contributor

@cgoncalves cgoncalves Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this and delete .adoc file?

cgoncalves
cgoncalves reviewed Oct 24, 2025
View reviewed changes
networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.adoc

ifndef::openshift-rosa,openshift-rosa-hcp[]
// The egressIPConfig object
include::modules/nw-egress-ips-config-object.adoc[leveloffset=+1]
Copy link
Contributor

@cgoncalves cgoncalves Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File hasn't been deleted yet.

Copy link
Contributor Author

@kquinn1204 kquinn1204 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try again not sure what is going on.

Copy link
Contributor Author

@kquinn1204 kquinn1204 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is now @cgoncalves

Copy link
Contributor

@cgoncalves cgoncalves Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not. The file still exists. Just to be clear, I'm talking about the file itself, not it being included in the doc.

@cgoncalves
Copy link
Contributor

cgoncalves commented Nov 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
lcavalle
lcavalle reviewed Nov 4, 2025
View reviewed changes
lcavalle
lcavalle reviewed Nov 4, 2025
View reviewed changes
lcavalle
lcavalle reviewed Nov 4, 2025
View reviewed changes
lcavalle
lcavalle reviewed Nov 4, 2025
View reviewed changes
lcavalle
lcavalle reviewed Nov 4, 2025
View reviewed changes
lcavalle
lcavalle reviewed Nov 4, 2025
View reviewed changes
@lcavalle
Copy link
Contributor

lcavalle commented Nov 4, 2025

/lgtm I have added a couple of suggestions and minor changes. Great work!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@kquinn1204: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@huiran0826
Copy link

huiran0826 commented Nov 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@slovern slovern added this to the Continuous Release milestone Nov 7, 2025
@slovern slovern merged commit d6746db into openshift:main Nov 7, 2025
2 checks passed
@slovern
Copy link
Contributor

slovern commented Nov 7, 2025

/cherrypick enterprise-4.21

@slovern
Copy link
Contributor

slovern commented Nov 7, 2025

/cherrypick enterprise-4.20

@slovern
Copy link
Contributor

slovern commented Nov 7, 2025

/cherrypick enterprise-4.19

@slovern
Copy link
Contributor

slovern commented Nov 7, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 7, 2025

@slovern: new pull request created: #102016

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 7, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 7, 2025

@slovern: new pull request created: #102017

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 7, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 7, 2025

@slovern: new pull request created: #102018

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 7, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 7, 2025

@slovern: #99999 failed to apply on top of branch "enterprise-4.18":

Applying: TELCODOCS-2477
Using index info to reconstruct a base tree...
M	networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.adoc
CONFLICT (content): Merge conflict in networking/ovn_kubernetes_network_provider/configuring-egress-ips-ovn.adoc
Removing modules/nw-egress-ips-config-object.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 TELCODOCS-2477

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cgoncalves cgoncalves cgoncalves left review comments

@lcavalle lcavalle lcavalle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cgoncalves cgoncalves

@huiran0826 huiran0826

Labels

branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@kquinn1204 @ocpdocs-previewbot @cgoncalves @lcavalle @huiran0826 @slovern @openshift-cherrypick-robot @openshift-merge-robot