Skip to content

OCPBUGS-55277: backport watch count tracking fixes to 4.18 #29725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2025
Merged

OCPBUGS-55277: backport watch count tracking fixes to 4.18 #29725

merged 3 commits into from
May 30, 2025

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Apr 25, 2025

Reverts #29720

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 25, 2025
@openshift-ci-robot
Copy link

@neisw: This pull request references Jira Issue OCPBUGS-55277, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55276 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-55276 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #29720

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@neisw
Copy link
Contributor Author

neisw commented Apr 26, 2025

/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 26, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9ace5d60-22a1-11f0-9561-ac54899db3e0-0

@neisw neisw marked this pull request as ready for review May 21, 2025 17:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2025
@openshift-ci openshift-ci bot requested review from sjenning and umohnani8 May 21, 2025 17:28
@neisw
Copy link
Contributor Author

neisw commented May 21, 2025

/retitle OCPBUGS-55277: backport watch count tracking fixes to 4.18

@openshift-ci openshift-ci bot changed the title Revert "Revert "OCPBUGS-55277: backport 4.18"" OCPBUGS-55277: backport watch count tracking fixes to 4.18 May 21, 2025
@neisw
Copy link
Contributor Author

neisw commented May 22, 2025

/retest -required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2025

@neisw: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aws-jenkins

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-image-registry

/test e2e-aws-ovn-microshift

/test e2e-aws-ovn-microshift-serial

/test e2e-aws-ovn-serial

/test e2e-gcp-ovn

/test e2e-gcp-ovn-builds

/test e2e-gcp-ovn-image-ecosystem

/test e2e-gcp-ovn-upgrade

/test e2e-metal-ipi-ovn-ipv6

/test images

/test lint

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd

/test e2e-aws

/test e2e-aws-csi

/test e2e-aws-disruptive

/test e2e-aws-etcd-certrotation

/test e2e-aws-etcd-recovery

/test e2e-aws-ovn

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-ipsec-serial

/test e2e-aws-ovn-kube-apiserver-rollout

/test e2e-aws-ovn-kubevirt

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-single-node-serial

/test e2e-aws-ovn-single-node-techpreview

/test e2e-aws-ovn-single-node-techpreview-serial

/test e2e-aws-ovn-single-node-upgrade

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-upgrade-rollback

/test e2e-aws-ovn-upi

/test e2e-aws-ovn-virt-techpreview

/test e2e-aws-proxy

/test e2e-azure

/test e2e-azure-ovn-etcd-scaling

/test e2e-azure-ovn-upgrade

/test e2e-baremetalds-kubevirt

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-external-vsphere-ccm

/test e2e-gcp-csi

/test e2e-gcp-disruptive

/test e2e-gcp-fips-serial

/test e2e-gcp-ovn-etcd-scaling

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-techpreview-serial

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview

/test e2e-metal-ipi-ovn-dualstack-bgp-techpreview

/test e2e-metal-ipi-ovn-dualstack-local-gateway

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

/test e2e-metal-ipi-serial

/test e2e-metal-ipi-serial-ovn-ipv6

/test e2e-metal-ipi-virtualmedia

/test e2e-metal-ovn-single-node-live-iso

/test e2e-metal-ovn-single-node-with-worker-live-iso

/test e2e-openstack-ovn

/test e2e-openstack-serial

/test e2e-vsphere

/test e2e-vsphere-ovn-dualstack-primaryv6

/test e2e-vsphere-ovn-etcd-scaling

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-release-4.18-e2e-agnostic-ovn-cmd

pull-ci-openshift-origin-release-4.18-e2e-aws-csi

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-cgroupsv2

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-edge-zones

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-fips

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-microshift

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-microshift-serial

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-serial

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-single-node

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-single-node-serial

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-single-node-upgrade

pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-upgrade

pull-ci-openshift-origin-release-4.18-e2e-gcp-csi

pull-ci-openshift-origin-release-4.18-e2e-gcp-ovn

pull-ci-openshift-origin-release-4.18-e2e-gcp-ovn-rt-upgrade

pull-ci-openshift-origin-release-4.18-e2e-gcp-ovn-upgrade

pull-ci-openshift-origin-release-4.18-e2e-metal-ipi-ovn

pull-ci-openshift-origin-release-4.18-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-origin-release-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-release-4.18-e2e-openstack-ovn

pull-ci-openshift-origin-release-4.18-images

pull-ci-openshift-origin-release-4.18-lint

pull-ci-openshift-origin-release-4.18-okd-scos-e2e-aws-ovn

pull-ci-openshift-origin-release-4.18-unit

pull-ci-openshift-origin-release-4.18-verify

pull-ci-openshift-origin-release-4.18-verify-deps

In response to this:

/retest -required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neisw
Copy link
Contributor Author

neisw commented May 22, 2025

/retest-required

1 similar comment
@neisw
Copy link
Contributor Author

neisw commented May 28, 2025

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2025 •
edited
Loading

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 7bbcd38 link false /test e2e-gcp-csi
ci/prow/e2e-gcp-ovn-rt-upgrade 7bbcd38 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/okd-scos-e2e-aws-ovn 7bbcd38 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 7bbcd38 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn 7bbcd38 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-agnostic-ovn-cmd 7bbcd38 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 7bbcd38 link false /test e2e-aws-ovn-kube-apiserver-rollout

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor

/label backport-risk-assessed
/label cherry-pick-approved
/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels May 30, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Contributor Author

neisw commented May 30, 2025

/override ci/prow/e2e-gcp-ovn-upgrade

Unrelated failure: API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade

Unrelated failure: API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 355ac86 into openshift:release-4.18 May 30, 2025
21 of 28 checks passed
@openshift-ci-robot
Copy link

@neisw: Jira Issue OCPBUGS-55277: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55277 has been moved to the MODIFIED state.

In response to this:

Reverts #29720

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202505301434.p0.g355ac86.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@sayan-biswas sayan-biswas

@kasturinarra kasturinarra

@Moebasim Moebasim

@jadhaj jadhaj

@pamoedom pamoedom

@prietyc123 prietyc123

@gangwgr gangwgr

@prabhapa prabhapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.