OCPBUGS-60472: networking, override join subnets for UDN and CUDN #30330
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@qinqon: This pull request references Jira Issue OCPBUGS-60472, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qinqon
force-pushed
the
ext-networking-udn-override-join-subnet
branch
from
d2c3acc to
dfebc53
Compare
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@qinqon: This pull request references Jira Issue OCPBUGS-60472, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
qinqon
force-pushed
the
ext-networking-udn-override-join-subnet
branch
from
dfebc53 to
2a6c4a6
Compare
|
/payload openstack/hypershift periodic-ci-openshift-hypershift-main-periodics-e2e-kubevirt-metal-ovn |
|
/payload-join periodic-ci-openshift-hypershift-main-periodics-e2e-kubevirt-metal-ovn |
|
/payload-job periodic-ci-openshift-hypershift-main-periodics-e2e-kubevirt-metal-ovn |
|
@qinqon: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-kubevirt-metal-ovn |
|
@qinqon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e666670-9ed7-11f0-8035-5ec0f8207dcf-0 |
|
Job Failure Risk Analysis for sha: 2a6c4a6
|
qinqon
force-pushed
the
ext-networking-udn-override-join-subnet
branch
2 times, most recently
from
e215755 to
ee1f3ae
Compare
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-kubevirt-metal-ovn |
|
@qinqon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9aa2320-9f61-11f0-9f3a-b3c76e25001c-0 |
|
/retest-required |
|
/payload periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-kubevirt-metal-ovn |
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-kubevirt-metal-ovn |
|
@qinqon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60bf14c0-9f79-11f0-9e44-71171b301bf7-0 |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-kubevirt-metal-ovn |
|
@qinqon: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7241c340-a047-11f0-82a2-ca26df8bd7f0-0 |
|
/test foo |
|
@qinqon: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-ovn-kubevirt |
|
Job Failure Risk Analysis for sha: ee1f3ae
|
|
@qinqon is |
Good catch we need those too, everything that uses join subnet 100.65 will fail when running at a hypershift kubevirt hosted cluster. @pperiyasamy I can try to do this checkin if "provider" is kubevirt but I don't know if it's really worth it since overriding subnet should works no matter what. |
qinqon
force-pushed
the
ext-networking-udn-override-join-subnet
branch
from
ee1f3ae to
15f3de5
Compare
|
@pperiyasamy I have push a chagne that also change the NADs. |
|
How do we test this ? is there a rehearsal we can run ? |
|
/test ? |
|
@pperiyasamy: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-ovn-kubevirt |
@maiqueb @pperiyasamy ideally we test this with the hypershift kubevirt metal periodic job since it's the one reportred at the jira periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-kubevirt-metal-ovn, but I think we may need to fix it since it's not able to install openshift virt (it do not have 4.21 version yet) and testing with 4.20 will not work since this origin PR is for 4.21 What do you prefer ? |
|
/retest-required |
|
/test e2e-baremetalds-kubevirt |
qinqon
force-pushed
the
ext-networking-udn-override-join-subnet
branch
from
15f3de5 to
394cd15
Compare
At hypershift kubevirt hosted clusters the default network join subnet is changed so it will not collide with the infra cluster one, this change use a different join subnet for UDNs so it will never collide with normal or kubevirt hosted ovnk clusters. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
ext-networking-udn-override-join-subnet
branch
from
394cd15 to
50e9080
Compare
|
Looks like we have a proper bug at ovn since secondaries layer2 are complaining about join subnet on hosted cluster |
Yeah, this is a bug for sure. There's no reason to care about the join subnet on a disconnected overlay. |
|
/hold we are trying to fix this at hypershift |
openshift-ci
bot
added
the
do-not-merge/hold
|
@qinqon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Close in favor of openshift/hypershift#6978 |
4 participants
At hypershift kubevirt hosted clusters the default network join subnet is changed so it will not collide with the infra cluster one, this change use a different join subnet for UDNs so it will never collide with normal or kubevirt hosted ovnk clusters.
Old PR changing the default network join subnet at hosted cluster: openshift/hypershift#1783