-
Notifications
You must be signed in to change notification settings - Fork 4.8k
NO-JIRA: implement WithoutKubeconf method to clear config path #30371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The WithoutKubeconf method was previously a no-op but now properly clears the configPath field to ensure OTP compatibility. This change makes the method functional by actually removing kubeconfig references when called, aligning with OTP's expected behavior.
@rioliu-rh: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
add a dummy test case in oc mirror test file g.It("OCPERT-173 Test oc cli w/o kubeconfig", func() {
output, err := oc.WithoutNamespace().WithoutKubeconf().Run("mirror").Args("--help").Output()
fmt.Println(output)
o.Expect(err).NotTo(o.HaveOccurred())
}) From the test log, I can see no option
error message |
/verified by @rioliu-rh |
@rioliu-rh: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @stbenjam |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rioliu-rh, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rioliu-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The
WithoutKubeconf
method was previously a no-op but now properly clears the configPath field to ensure OTP compatibility. This change makes the method functional by actually removing kubeconfig references when called, aligning with OTP's expected behavior.link jira ticket https://issues.redhat.com/browse/OCPERT-173